Don't enforce trailing shape on empty arrays

QuLogic · QuLogic · commit 086add18d724 · 2024-10-01T22:24:18.000-04:00
They need only be the same number of dimensions, as sometimes code does
`np.atleast_3d(array)` on something empty, which inserts the 0-dimension
in a spot that messes with the expected trailing shape.
diff --git a/src/mplutils.h b/src/mplutils.h
@@ -77,6 +77,11 @@ inline bool check_trailing_shape(T array, char const* name, long d1)
                      array.ndim());
         return false;
     }
+    if (array.size() == 0) {
+        // Sometimes things come through as atleast_2d, etc., but they're empty, so
+        // don't bother enforcing the trailing shape.
+        return true;
+    }
     if (array.shape(1) != d1) {
         PyErr_Format(PyExc_ValueError,
                      "%s must have shape (N, %ld), got (%ld, %ld)",
@@ -95,6 +100,11 @@ inline bool check_trailing_shape(T array, char const* name, long d1, long d2)
                      array.ndim());
         return false;
     }
+    if (array.size() == 0) {
+        // Sometimes things come through as atleast_3d, etc., but they're empty, so
+        // don't bother enforcing the trailing shape.
+        return true;
+    }
     if (array.shape(1) != d1 || array.shape(2) != d2) {
         PyErr_Format(PyExc_ValueError,
                      "%s must have shape (N, %ld, %ld), got (%ld, %ld, %ld)",
