replace Path.get_extents instead of adding new API

brunobeltran · brunobeltran · commit 0b1b23a042fa · 2020-03-30T17:36:45.000-07:00
diff --git a/lib/matplotlib/path.py b/lib/matplotlib/path.py
@@ -587,38 +587,26 @@ def contains_path(self, path, transform=None):
             transform = transform.frozen()
         return _path.path_in_path(self, None, path, transform)
 
-    def get_extents(self, transform=None):
-        """
-        Return the extents (*xmin*, *ymin*, *xmax*, *ymax*) of the path.
-
-        Unlike computing the extents on the *vertices* alone, this
-        algorithm will take into account the curves and deal with
-        control points appropriately.
-        """
-        from .transforms import Bbox
-        path = self
-        if transform is not None:
-            transform = transform.frozen()
-            if not transform.is_affine:
-                path = self.transformed(transform)
-                transform = None
-        return Bbox(_path.get_path_extents(path, transform))
-
-    def get_exact_extents(self, **kwargs):
+    def get_extents(self, transform=None, **kwargs):
         """Get size of Bbox of curve (instead of Bbox of control points).
 
         Parameters
         ----------
+        transform : matplotlib.transforms.Transform, optional
+            Transform to apply to path before computing extents, if any.
         kwargs : Dict[str, object]
             Forwarded to self.iter_bezier.
 
         Returns
         -------
-        extents : (4,) float, array_like
-            The extents of the path (xmin, ymin, xmax, ymax).
+        bbox : matplotlib.transforms.Bbox
+            The extents of the path Bbox([[xmin, ymin], [xmax, ymax]])
         """
+        from .transforms import Bbox
+        if transform is not None:
+            self = transform.transform_path(self)
         maxi = 2  # [xmin, ymin, *xmax, ymax]
-        # return value for empty paths to match _path.h
+        # return value for empty paths to match what used to be done in _path.h
         extents = np.array([np.inf, np.inf, -np.inf, -np.inf])
         for curve, code in self.iter_bezier(**kwargs):
             # start and endpoints can be extrema of the curve
@@ -628,10 +616,10 @@ def get_exact_extents(self, **kwargs):
             _, dzeros = curve.axis_aligned_extrema
             if len(dzeros) == 0:
                 continue
-            for zero in dzeros:
-                potential_extrema = curve.point_at_t(zero)
+            for ti in dzeros:
+                potential_extrema = curve.point_at_t(ti)
                 _update_extents(extents, potential_extrema)
-        return extents
+        return Bbox.from_extents(extents)
 
     def intersects_path(self, other, filled=True):
         """
diff --git a/lib/matplotlib/tests/test_path.py b/lib/matplotlib/tests/test_path.py
@@ -52,7 +52,7 @@ def test_contains_points_negative_radius():
 def test_exact_extents_cubic():
     hard_curve = Path([[0, 0], [1, 0], [1, 1], [0, 1]],
                       [Path.MOVETO, Path.CURVE4, Path.CURVE4, Path.CURVE4])
-    np.testing.assert_equal(hard_curve.get_exact_extents(), [0., 0., 0.75, 1.])
+    assert(hard_curve.get_extents().bounds == (0., 0., 0.75, 1.))
 
 
 def test_point_in_path_nan():
