ENH: make get_position apply aspect

jklymak · jklymak · commit 0b80a41137a6 · 2017-11-25T15:42:16.000-08:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -854,28 +854,43 @@ def _update_transScale(self):
                     pass
 
     def get_position(self, original=False):
-        'Return the a copy of the axes rectangle as a Bbox'
+        """
+        Return the a copy of the axes rectangle as a Bbox
+
+        Parameters
+        ----------
+        original : bool
+          If True return the original Axes position.  If False
+          (the default), then return the current position.
+
+        Returns
+        -------
+        ret : bbox
+        """
         if original:
             return self._originalPosition.frozen()
         else:
+            self.apply_aspect()
             return self._position.frozen()
 
     def set_position(self, pos, which='both'):
-        """Set the axes position
-
-        The expected shape of ``pos`` is::
+        """
+        Set the axes position
 
-          pos = [left, bottom, width, height]
+        Parameters
+        ----------
+        pos : tuple of four floats or `~matplotlib.transforms.Bbox`
+          The tuple is of the form::
 
-        in relative 0,1 coords, or *pos* can be a
-        :class:`~matplotlib.transforms.Bbox`
+            pos = [left, bottom, width, height]
 
-        There are two position variables: one which is ultimately
-        used, but which may be modified by :meth:`apply_aspect`, and a
-        second which is the starting point for :meth:`apply_aspect`.
+          in relative 0,1 figure coordinates, or *pos* can be a
+          :class:`~matplotlib.transforms.Bbox`
 
-        Optional keyword arguments:
-          *which*
+        which : string
+          There are two position variables: one which is ultimately
+          used, but which may be modified by :meth:`apply_aspect`, and a
+          second which is the starting point for :meth:`apply_aspect`.
 
             ==========   ====================
             value        description
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -1165,7 +1165,7 @@ def make_axes(parents, location=None, orientation=None, fraction=0.15,
 
     # transform each of the axes in parents using the new transform
     for ax in parents:
-        new_posn = shrinking_trans.transform(ax.get_position())
+        new_posn = shrinking_trans.transform(ax.get_position(original=True))
         new_posn = mtransforms.Bbox(new_posn)
         ax.set_position(new_posn)
         if parent_anchor is not False:
