API: forward figure resize to the manager

tacaswell · tacaswell · commit 0d817d08e038 · 2016-03-07T23:08:45.000-05:00
Do not re-forward in calls to `set_size_inches` generated via callbacks in the GUI backends. This pevents 'jumping' as the window is resized with the mouse. closes #4680
diff --git a/lib/matplotlib/backends/backend_cocoaagg.py b/lib/matplotlib/backends/backend_cocoaagg.py
@@ -178,7 +178,7 @@ def updatePlot(self):
     def windowDidResize_(self, sender):
         w,h = self.bounds().size
         dpi = self.canvas.figure.dpi
-        self.canvas.figure.set_size_inches(w / dpi, h / dpi)
+        self.canvas.figure.set_size_inches(w / dpi, h / dpi, forward=False)
         self.canvas.draw()
         self.updatePlot()
 
diff --git a/lib/matplotlib/backends/backend_gtk.py b/lib/matplotlib/backends/backend_gtk.py
@@ -355,7 +355,7 @@ def configure_event(self, widget, event):
 
         # resize the figure (in inches)
         dpi = self.figure.dpi
-        self.figure.set_size_inches (w/dpi, h/dpi)
+        self.figure.set_size_inches(w/dpi, h/dpi, forward=False)
         self._need_redraw = True
 
         return False  # finish event propagation?
diff --git a/lib/matplotlib/backends/backend_gtk3.py b/lib/matplotlib/backends/backend_gtk3.py
@@ -285,7 +285,7 @@ def size_allocate(self, widget, allocation):
         dpival = self.figure.dpi
         winch = allocation.width / dpival
         hinch = allocation.height / dpival
-        self.figure.set_size_inches(winch, hinch)
+        self.figure.set_size_inches(winch, hinch, forward=False)
         FigureCanvasBase.resize_event(self)
         self.draw_idle()
 
@@ -318,7 +318,7 @@ def configure_event(self, widget, event):
 
         # resize the figure (in inches)
         dpi = self.figure.dpi
-        self.figure.set_size_inches (w/dpi, h/dpi)
+        self.figure.set_size_inches(w/dpi, h/dpi, forward=False)
         self._need_redraw = True
 
         return False  # finish event propagation?
diff --git a/lib/matplotlib/backends/backend_gtkagg.py b/lib/matplotlib/backends/backend_gtkagg.py
@@ -75,7 +75,7 @@ def configure_event(self, widget, event=None):
         dpival = self.figure.dpi
         winch = w/dpival
         hinch = h/dpival
-        self.figure.set_size_inches(winch, hinch)
+        self.figure.set_size_inches(winch, hinch, forward=False)
         self._need_redraw = True
         self.resize_event()
         if DEBUG: print('FigureCanvasGTKAgg.configure_event end')
diff --git a/lib/matplotlib/backends/backend_macosx.py b/lib/matplotlib/backends/backend_macosx.py
@@ -322,7 +322,7 @@ def resize(self, width, height):
         dpi = self.figure.dpi
         width /= dpi
         height /= dpi
-        self.figure.set_size_inches(width, height)
+        self.figure.set_size_inches(width, height, forward=False)
         FigureCanvasBase.resize_event(self)
 
     def _print_bitmap(self, filename, *args, **kwargs):
diff --git a/lib/matplotlib/backends/backend_qt5.py b/lib/matplotlib/backends/backend_qt5.py
@@ -331,7 +331,7 @@ def resizeEvent(self, event):
         dpival = self.figure.dpi
         winch = w / dpival
         hinch = h / dpival
-        self.figure.set_size_inches(winch, hinch)
+        self.figure.set_size_inches(winch, hinch, forward=False)
         FigureCanvasBase.resize_event(self)
         self.draw_idle()
         QtWidgets.QWidget.resizeEvent(self, event)
diff --git a/lib/matplotlib/backends/backend_tkagg.py b/lib/matplotlib/backends/backend_tkagg.py
@@ -272,7 +272,7 @@ def resize(self, event):
         dpival = self.figure.dpi
         winch = width/dpival
         hinch = height/dpival
-        self.figure.set_size_inches(winch, hinch)
+        self.figure.set_size_inches(winch, hinch, forward=False)
 
 
         self._tkcanvas.delete(self._tkphoto)
diff --git a/lib/matplotlib/backends/backend_webagg_core.py b/lib/matplotlib/backends/backend_webagg_core.py
@@ -346,7 +346,7 @@ def handle_resize(self, event):
         x, y = int(x), int(y)
         fig = self.figure
         # An attempt at approximating the figure size in pixels.
-        fig.set_size_inches(x / fig.dpi, y / fig.dpi)
+        fig.set_size_inches(x / fig.dpi, y / fig.dpi, forward=False)
 
         _, _, w, h = self.figure.bbox.bounds
         # Acknowledge the resize, and force the viewer to update the
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py
@@ -985,7 +985,7 @@ def _onSize(self, evt):
         dpival = self.figure.dpi
         winch = self._width / dpival
         hinch = self._height / dpival
-        self.figure.set_size_inches(winch, hinch)
+        self.figure.set_size_inches(winch, hinch, forward=False)
 
         # Rendering will happen on the associated paint event
         # so no need to do anything here except to make sure
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -667,7 +667,7 @@ def figimage(self, X,
         self.stale = True
         return im
 
-    def set_size_inches(self, w, h=None, forward=False):
+    def set_size_inches(self, w, h=None, forward=True):
         """
         set_size_inches(w,h, forward=False)
 
