Add set_offsets to quiver and make the attribute (N and XY) properties to avoid inconsistent state of quiver

ericpre · ericpre · commit 10adf0b6b906 · 2024-03-23T09:37:24.000Z
diff --git a/lib/matplotlib/quiver.py b/lib/matplotlib/quiver.py
@@ -447,7 +447,7 @@ class Quiver(mcollections.PolyCollection):
     The API methods are set_UVC(), set_U(), set_V() and set_C(), which
     can be used to change the size, orientation, and color of the
     arrows; their locations are fixed when the class is
-    instantiated.  Possibly this method will be useful
+    instantiated.  Possibly these methods will be useful
     in animations.
 
     Much of the work in this class is done in the draw()
@@ -475,8 +475,6 @@ def __init__(self, ax, *args,
         X, Y, U, V, C = _parse_args(*args, caller_name='quiver')
         self.X = X
         self.Y = Y
-        self.XY = np.column_stack((X, Y))
-        self.N = len(X)
         self.scale = scale
         self.headwidth = headwidth
         self.headlength = float(headlength)
@@ -523,6 +521,14 @@ def _init(self):
 
             self._dpi_at_last_init = self.axes.figure.dpi
 
+    @property
+    def N(self):
+        return len(self.X)
+
+    @property
+    def XY(self):
+        return np.column_stack((self.X, self.Y))
+
     def get_datalim(self, transData):
         trans = self.get_transform()
         offset_trf = self.get_offset_transform()
@@ -588,6 +594,7 @@ def set_UVC(self, U, V, C=None):
             The size must the same as the existing U, V or be one.
         C : array-like or None, optional
             The arrow colors. The default is None.
+            The size must the same as the existing U, V or be one.
         """
         if U is None:
             U = self.U
@@ -619,6 +626,19 @@ def set_UVC(self, U, V, C=None):
             self.set_array(C)
         self.stale = True
 
+    def set_offsets(self, xy):
+        """
+        Set the offsets for the arrows.  This saves the offsets passed
+        in and masks them as appropriate for the existing X/Y data.
+
+        Parameters
+        ----------
+        xy : sequence of pairs of floats
+        """
+        self.X, self.Y = xy[:, 0], xy[:, 1]
+        super().set_offsets(xy)
+        self.stale = True
+
     def _dots_per_unit(self, units):
         """Return a scale factor for converting from units to pixels."""
         bb = self.axes.bbox
diff --git a/lib/matplotlib/quiver.pyi b/lib/matplotlib/quiver.pyi
@@ -54,11 +54,9 @@ class QuiverKey(martist.Artist):
 class Quiver(mcollections.PolyCollection):
     X: ArrayLike
     Y: ArrayLike
-    XY: ArrayLike
     U: ArrayLike
     V: ArrayLike
     Umask: ArrayLike
-    N: int
     scale: float | None
     headwidth: float
     headlength: float
@@ -121,13 +119,18 @@ class Quiver(mcollections.PolyCollection):
         pivot: Literal["tail", "mid", "middle", "tip"] = ...,
         **kwargs
     ) -> None: ...
+    @property
+    def N(self) -> int: ...
+    @property
+    def XY(self) -> ArrayLike: ...
     def get_datalim(self, transData: Transform) -> Bbox: ...
     def set_U(self, U: ArrayLike) -> None: ...
     def set_V(self, V: ArrayLike) -> None: ...
     def set_C(self, C: ArrayLike) -> None: ...
     def set_UVC(
         self, U: ArrayLike | None, V: ArrayLike | None, C: ArrayLike | None = ...
     ) -> None: ...
+    def set_offsets(self, xy: ArrayLike) -> None: ...
 
 class Barbs(mcollections.PolyCollection):
     sizes: dict[str, float]
diff --git a/lib/matplotlib/tests/test_collections.py b/lib/matplotlib/tests/test_collections.py
@@ -376,6 +376,9 @@ def test_quiver_offsets():
     qc.set_offsets(new_offsets)
 
     np.testing.assert_allclose(qc.get_offsets(), new_offsets)
+    np.testing.assert_allclose(qc.X, new_offsets[::, 0])
+    np.testing.assert_allclose(qc.Y, new_offsets[::, 1])
+    np.testing.assert_allclose(qc.XY, new_offsets)
 
 
 def test_quiver_UVC():
