Merge pull request #4201 from cimarronm/text_patheffects_renderer

tacaswell · tacaswell · commit 111d74a70429 · 2015-03-08T21:44:00.000-04:00
Bug : in text draw method when path_effects are set

Make sure inner loops do not clobber the function-level renderer
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -639,16 +639,18 @@ def draw(self, renderer):
 
             if self.get_path_effects():
                 from matplotlib.patheffects import PathEffectRenderer
-                renderer = PathEffectRenderer(self.get_path_effects(),
-                                              renderer)
+                textrenderer = PathEffectRenderer(self.get_path_effects(),
+                                                  renderer)
+            else:
+                textrenderer = renderer
 
             if self.get_usetex():
-                renderer.draw_tex(gc, x, y, clean_line,
-                                  self._fontproperties, angle, mtext=mtext)
+                textrenderer.draw_tex(gc, x, y, clean_line,
+                                      self._fontproperties, angle, mtext=mtext)
             else:
-                renderer.draw_text(gc, x, y, clean_line,
-                                   self._fontproperties, angle,
-                                   ismath=ismath, mtext=mtext)
+                textrenderer.draw_text(gc, x, y, clean_line,
+                                       self._fontproperties, angle,
+                                       ismath=ismath, mtext=mtext)
 
         gc.restore()
         renderer.close_group('text')
