Let SecondaryAxis inherit get_tightbbox from _AxesBase.

anntzer · anntzer · commit 119228bc0d65 · 2019-06-06T21:59:14.000+02:00
The only difference in the implementation of _AxesBase.get_tightbbox and
SecondaryAxis.get_tightbbox is that the latter explicitly ignores the
axis in the "other" direction, but because that axis is set to
invisible, its tightbbox is None.  So we can just directly inherit the
parent implementation.
diff --git a/lib/matplotlib/axes/_secondary_axes.py b/lib/matplotlib/axes/_secondary_axes.py
@@ -306,44 +306,6 @@ def _set_lims(self):
             lims = lims[::-1]
         set_lim(lims)
 
-    def get_tightbbox(self, renderer, call_axes_locator=True):
-        """
-        Return the tight bounding box of the axes.
-        The dimension of the Bbox in canvas coordinate.
-
-        If *call_axes_locator* is *False*, it does not call the
-        _axes_locator attribute, which is necessary to get the correct
-        bounding box. ``call_axes_locator==False`` can be used if the
-        caller is only intereted in the relative size of the tightbbox
-        compared to the axes bbox.
-        """
-
-        bb = []
-
-        if not self.get_visible():
-            return None
-
-        self._set_lims()
-        locator = self.get_axes_locator()
-        if locator and call_axes_locator:
-            pos = locator(self, renderer)
-            self.apply_aspect(pos)
-        else:
-            self.apply_aspect()
-
-        if self._orientation == 'x':
-            bb_axis = self.xaxis.get_tightbbox(renderer)
-        else:
-            bb_axis = self.yaxis.get_tightbbox(renderer)
-        if bb_axis:
-            bb.append(bb_axis)
-
-        bb.append(self.get_window_extent(renderer))
-        _bbox = mtransforms.Bbox.union(
-            [b for b in bb if b.width != 0 or b.height != 0])
-
-        return _bbox
-
     def set_aspect(self, *args, **kwargs):
         """
         Secondary axes cannot set the aspect ratio, so calling this just
