Deprecate dviread.Encoding.

anntzer · anntzer · commit 133075336a1d · 2020-03-11T11:52:44.000+01:00
In 2c0f5ec I found that dviread.Encoding was mostly broken (it didn't correctly split entries in the encoding file and instead returned everything concatenated as a single string) and introduced _parse_enc to make usetex loading work in SVG. I didn't deprecate Encoding yet because it appeared to work for the pdf backend. As it turns out it "works" because the format needed by the pdf backend is exactly the same as the one in enc files, so it doesn't mind the failure to split the string. Still, using a proper parser (_parse_enc) seems better... So deprecate the broken Encoding.
diff --git a/doc/api/next_api_changes/deprecations.rst b/doc/api/next_api_changes/deprecations.rst
@@ -307,3 +307,7 @@ The *quality*, *optimize*, and *progressive* keyword arguments to
 
 Such options should now be directly passed to Pillow using
 ``savefig(..., pil_kwargs={"quality": ..., "optimize": ..., "progressive": ...})``.
+
+``dviread.Encoding``
+~~~~~~~~~~~~~~~~~~~~
+This class was (mostly) broken and is deprecated.
diff --git a/lib/matplotlib/backends/backend_pdf.py b/lib/matplotlib/backends/backend_pdf.py
@@ -763,7 +763,7 @@ def _embedTeXFont(self, fontinfo):
 
         # Encoding (if needed)
         if fontinfo.encodingfile is not None:
-            enc = dviread.Encoding(fontinfo.encodingfile)
+            enc = dviread._parse_enc(fontinfo.encodingfile)
             differencesArray = [Name(ch) for ch in enc]
             differencesArray = [0] + differencesArray
             fontdict['Encoding'] = \
diff --git a/lib/matplotlib/dviread.py b/lib/matplotlib/dviread.py
@@ -919,6 +919,7 @@ def _parse(self, file):
                 encoding=encoding, filename=filename)
 
 
+@cbook.deprecated("3.3")
 class Encoding:
     r"""
     Parses a \*.enc file referenced from a psfonts.map style file.
