cleaning up OptionalBackendPackage a tiny bit

megies · megies · commit 162cf1256494 · 2013-08-27T00:03:11.000+02:00
- check for `if config is not None` before the try/except/pass adds
   nothing, just makes it less readable
 - much clearer to handle of the default value of the `install` variable
   with the base class and not nested in a try/except of the
   `get_config` method (and even duplicated outside of the try/except)
 - the `force` attribute (only used for BackendAgg right now it seems)
   should also have a more prominent default state in the base class
   rather than in just one subclass
diff --git a/setupext.py b/setupext.py
@@ -455,18 +455,17 @@ def check(self):
 
 class OptionalBackendPackage(SetupPackage):
     optional = True
+    force = False
+    install = 'auto'
 
     def get_config(self):
-        install = 'auto'
-        if config is not None:
-            try:
-                install = config.getboolean(
-                    'gui_support', self.name)
-            except:
-                install = 'auto'
-        if install is True:
+        try:
+            self.install = config.getboolean('gui_support', self.name)
+        except:
+            pass
+        if self.install is True:
             self.optional = False
-        return install
+        return self.install
 
 
 class Platform(SetupPackage):
@@ -981,7 +980,6 @@ def get_install_requires(self):
 
 class BackendAgg(OptionalBackendPackage):
     name = "agg"
-    force = False
 
     def check(self):
         # The Agg backend extension needs to be built even
