Fixing

jklymak · jklymak · commit 1bed724cf599 · 2018-08-05T10:34:04.000-07:00
diff --git a/lib/matplotlib/_constrained_layout.py b/lib/matplotlib/_constrained_layout.py
@@ -181,7 +181,8 @@ def do_constrained_layout(fig, renderer, h_pad, w_pad,
             sup = fig._suptitle
             bbox = invTransFig(sup.get_window_extent(renderer=renderer))
             height = bbox.y1 - bbox.y0
-            sup._layoutbox.edit_height(height+h_pad)
+            if np.isfinite(height):
+                sup._layoutbox.edit_height(height+h_pad)
 
         # OK, the above lines up ax._poslayoutbox with ax._layoutbox
         # now we need to
@@ -267,10 +268,17 @@ def _make_layout_margins(ax, renderer, h_pad, w_pad):
     """
     fig = ax.figure
     invTransFig = fig.transFigure.inverted().transform_bbox
-
+    print('ax', ax, invTransFig)
     pos = ax.get_position(original=True)
     tightbbox = ax.get_tightbbox(renderer=renderer)
+    print(pos, tightbbox)
     bbox = invTransFig(tightbbox)
+    print('bbox', bbox)
+    # this can go wrong:
+    if not np.isfinite(bbox.y0 + bbox.x0 + bbox.y1 + bbox.x1):
+        # just abort, this is likely a bad set of co-ordinates that
+        # is transitory...
+        return
     # use stored h_pad if it exists
     h_padt = ax._poslayoutbox.h_pad
     if h_padt is None:
@@ -288,6 +296,8 @@ def _make_layout_margins(ax, renderer, h_pad, w_pad):
     _log.debug('left %f', (-bbox.x0 + pos.x0 + w_pad))
     _log.debug('right %f', (bbox.x1 - pos.x1 + w_pad))
     _log.debug('bottom %f', (-bbox.y0 + pos.y0 + h_padt))
+    _log.debug('bbox.y0 %f', bbox.y0)
+    _log.debug('pos.y0 %f', pos.y0)
     # Sometimes its possible for the solver to collapse
     # rather than expand axes, so they all have zero height
     # or width.  This stops that...  It *should* have been
diff --git a/lib/matplotlib/axes/_secondary_axes.py b/lib/matplotlib/axes/_secondary_axes.py
@@ -89,6 +89,9 @@ def __init__(self, parent, orientation,
             self._axis = self.yaxis
             self._locstrings = ['right', 'left']
             self._otherstrings = ['top', 'bottom']
+        # this gets positioned w/o constrained_layout so exclude:
+        self._layoutbox = None
+        self._poslayoutbox = None
 
         self.set_location(location)
         self.set_conversion(conversion, self._otherargs)
@@ -241,10 +244,11 @@ def set_conversion(self, conversion, otherargs=None):
         # make the _convert function...
         if isinstance(conversion, mtransforms.Transform):
             self._convert = conversion
-            set_scale('arbitrary', transform=conversion.inverted())
+
+            self.set_xscale('arbitrary', transform=conversion.inverted())
         elif isinstance(conversion, str):
             self._convert = _parse_conversion(conversion, otherargs)
-            set_scale('arbitrary', transform=self._convert.inverted())
+            self.set_xscale('arbitrary', transform=self._convert.inverted())
         else:
             # linear conversion with offset
             if isinstance(conversion, numbers.Number):
@@ -271,29 +275,19 @@ def draw(self, renderer=None, inframe=False):
         parameter when axes initialized.)
 
         """
-        # check parent scale...  Make these match....
-        if self._orientation == 'x':
-            scale = self._parent.get_xscale()
-            self.set_xscale(scale)
-        if self._orientation == 'y':
-            scale = self._parent.get_yscale()
-            self.set_yscale(scale)
 
         if self._orientation == 'x':
             lims = self._parent.get_xlim()
             set_lim = self.set_xlim
         if self._orientation == 'y':
             lims = self._parent.get_ylim()
             set_lim = self.set_ylim
-        print('parent', lims)
         order = lims[0] < lims[1]
         lims = self._convert.transform(lims)
         neworder = lims[0] < lims[1]
         if neworder != order:
             # flip because the transform will take care of the flipping..
-            # lims = lims[::-1]
-            pass
-        print('childs', lims)
+            lims = lims[::-1]
 
         set_lim(lims)
         super().draw(renderer=renderer, inframe=inframe)
@@ -480,9 +474,7 @@ def __init__(self, fac):
         self._fac = fac
 
     def transform_non_affine(self, values):
-        with np.errstate(divide="ignore", invalid="ignore"):
-            q = self._fac / values
-        print('q', values, q)
+        q = self._fac / values
         return q
 
     def inverted(self):
@@ -555,7 +547,6 @@ def get_transform(self):
         The transform for linear scaling is just the
         :class:`~matplotlib.transforms.IdentityTransform`.
         """
-        print('tranform', self._transform)
         return self._transform
 
     def set_default_locators_and_formatters(self, axis):
