Should fix broken unit tests 'polar_axes' and 'polar_coords' in test_axes

Adrien VINCENT · Adrien VINCENT · commit 1df0f7e64dde · 2016-02-25T16:18:00.000+01:00
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -2158,11 +2158,17 @@ def _update_position_xytext(self, renderer, xy_pixel):
                         " use 'headlength' to set the head length in points.")
                 headlength = d.pop('headlength', 12)
 
-                to_style = self.figure.dpi / (72 * ms)
-
-                stylekw = dict(head_length=headlength * to_style,
-                               head_width=headwidth * to_style,
-                               tail_width=width * to_style)
+                # Old way:
+                # ms_pix = renderer.points_to_pixels(ms)
+                # to_style = self.figure.dpi / (72 * ms_pix)
+                # NB: is there a reason to use self.figure.dpi / (72 * ms_pix)
+                # instead of renderer.points_to_pixels(1.) / ms_pix? Both
+                # should be equal to '1 / ms', shouldn't they (by the way)?
+                #
+                # New way: '* to_style' <- '/ ms' (ms is now still in pts here)
+                stylekw = dict(head_length=headlength / ms,
+                               head_width=headwidth / ms,
+                               tail_width=width / ms)
 
                 self.arrow_patch.set_arrowstyle('simple', **stylekw)
 
