Merge pull request #13603 from jklymak/fix-bail-tight-layout

QuLogic · web-flow · commit 22bbbae96aa7 · 2019-03-08T04:03:00.000-05:00
FIX: continue to bail tight layout if rect supplied
diff --git a/lib/matplotlib/tests/test_tightlayout.py b/lib/matplotlib/tests/test_tightlayout.py
@@ -323,3 +323,5 @@ def test_collapsed():
         plt.tight_layout()
         p2 = ax.get_position()
         assert p1.width == p2.width
+    # test that passing a rect doesn't crash...
+    plt.tight_layout(rect=[0, 0, 0.8, 0.8])
diff --git a/lib/matplotlib/tight_layout.py b/lib/matplotlib/tight_layout.py
@@ -361,7 +361,8 @@ def get_tight_layout_figure(fig, axes_list, subplotspec_list, renderer,
                                      ax_bbox_list=ax_bbox_list,
                                      pad=pad, h_pad=h_pad, w_pad=w_pad)
 
-    if rect is not None:
+    # kwargs can be none if tight_layout fails...
+    if rect is not None and kwargs is not None:
         # if rect is given, the whole subplots area (including
         # labels) will fit into the rect instead of the
         # figure. Note that the rect argument of
