Don't pass "wrong" indent=False in SVG generation.

anntzer · anntzer · commit 23664df6c3d5 · 2020-06-18T15:52:56.000+02:00
All kwargs to `XMLWriter.element()` are interpreted as XML attributes --
except the Falsy ones.  So passing `indent=False` doesn't have any
effect, but it's wrong to pass `indent` to `element()` anyways (e.g.
passing `indent=True` would crash it instead of doing any indenting).
diff --git a/lib/matplotlib/backends/backend_svg.py b/lib/matplotlib/backends/backend_svg.py
@@ -334,7 +334,7 @@ def _write_metadata(self, metadata):
         writer = self.writer
 
         if 'Title' in metadata:
-            writer.element('title', text=metadata['Title'], indent=False)
+            writer.element('title', text=metadata['Title'])
 
         # Special handling.
         date = metadata.get('Date', None)
@@ -387,7 +387,7 @@ def _write_metadata(self, metadata):
                     'identifier', 'language', 'relation', 'source']:
             info = metadata.pop(key.title(), None)
             if info is not None:
-                writer.element(f'dc:{key}', text=info, indent=False)
+                writer.element(f'dc:{key}', text=info)
 
         # Multiple Agent values.
         for key in ['creator', 'contributor', 'publisher', 'rights']:
@@ -401,7 +401,7 @@ def _write_metadata(self, metadata):
             writer.start(f'dc:{key}')
             for agent in agents:
                 writer.start('cc:Agent')
-                writer.element('dc:title', text=agent, indent=False)
+                writer.element('dc:title', text=agent)
                 writer.end('cc:Agent')
             writer.end(f'dc:{key}')
 
@@ -414,7 +414,7 @@ def _write_metadata(self, metadata):
             writer.start('dc:subject')
             writer.start('rdf:Bag')
             for keyword in keywords:
-                writer.element('rdf:li', text=keyword, indent=False)
+                writer.element('rdf:li', text=keyword)
             writer.end('rdf:Bag')
             writer.end('dc:subject')
 
