Use default value for invalid key instead of NULL

Xarthisius · Xarthisius · commit 2451840c1e35 · 2016-10-30T23:45:07.000-05:00
diff --git a/src/_png.cpp b/src/_png.cpp
@@ -318,7 +318,7 @@ static PyObject *Py_write_png(PyObject *self, PyObject *args, PyObject *kwds)
             } else if (PyBytes_Check(meta_key)) {
                 text[meta_pos].key = PyBytes_AsString(meta_key);
             } else {
-                text[meta_pos].key = NULL;  // Silently drops entry
+                text[meta_pos].key = (char *)"INVALID KEY";
             }
             if (PyUnicode_Check(meta_val)) {
                 PyObject *temp_val = PyUnicode_AsEncodedString(meta_val, "latin_1", "strict");

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ static PyObject Py_write_png(PyObject self, PyObject args, PyObject kwds)`
`318`	`318`	`} else if (PyBytes_Check(meta_key)) {`
`319`	`319`	`text[meta_pos].key = PyBytes_AsString(meta_key);`
`320`	`320`	`} else {`
`321`		`- text[meta_pos].key = NULL; // Silently drops entry`
	`321`	`+ text[meta_pos].key = (char *)"INVALID KEY";`
`322`	`322`	`}`
`323`	`323`	`if (PyUnicode_Check(meta_val)) {`
`324`	`324`	`PyObject *temp_val = PyUnicode_AsEncodedString(meta_val, "latin_1", "strict");`