TST: test pyplot.pie with a data kwarg

jankatins · jankatins · commit 25b1d43da08f · 2015-08-31T12:06:51.000+02:00
pie was a method, which did not work with a data kwarg as it
didn't have a **kwargs catch all which would make pyplot.pie pass
this argument to the decorated function.

Document that the decorated functions are tested in the axes test
cases.
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -3726,7 +3726,8 @@ def test_text_labelsize():
     ax.tick_params(direction='out')
 
 
-@image_comparison(baseline_images=['pie_linewidth_0', 'pie_linewidth_0'],
+@image_comparison(baseline_images=['pie_linewidth_0', 'pie_linewidth_0',
+                                   'pie_linewidth_0'],
                   extensions=['png'])
 def test_pie_linewidth_0():
     # The slices will be ordered and plotted counter-clockwise.
@@ -3743,14 +3744,21 @@ def test_pie_linewidth_0():
 
     # Reuse testcase from above for a labeled data test
     data = {"l": labels, "s": sizes, "c": colors, "ex": explode}
-    # FIXME: Workaround until the pyplot is regenerated
     fig = plt.figure()
     ax = fig.gca()
     ax.pie("s", explode="ex", labels="l", colors="c",
             autopct='%1.1f%%', shadow=True, startangle=90,
             wedgeprops={'linewidth': 0}, data=data)
     ax.axis('equal')
 
+    # And again to test the pyplot functions which should also be able to be
+    # called with a data kwarg
+    plt.figure()
+    plt.pie("s", explode="ex", labels="l", colors="c",
+            autopct='%1.1f%%', shadow=True, startangle=90,
+            wedgeprops={'linewidth': 0}, data=data)
+    plt.axis('equal')
+
 
 @image_comparison(baseline_images=['pie_center_radius'], extensions=['png'])
 def test_pie_center_radius():
diff --git a/lib/matplotlib/tests/test_labeled_data_unpacking.py b/lib/matplotlib/tests/test_labeled_data_unpacking.py
@@ -30,6 +30,11 @@ def noop(txt, regex):
 def is_list_like(obj):
     return not is_string_like(obj) and iterable(obj)
 
+# Notes on testing the plotting functions itself
+# *   the individual decorated plotting functions are tested in 'test_axes.py'
+# *   that pyplot functions accept a data kwarg is only tested in
+#     test_axes.test_pie_linewidth_0
+
 
 # stolen from pandas
 @contextmanager
