RR - fix axes vlines and hlines using wrong coordinates

robrighter · robrighter · commit 29e4ea154aac · 2023-03-01T00:12:08.000-05:00
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -1113,7 +1113,7 @@ def hlines(self, y, xmin, xmax, colors=None, linestyles='solid',
     @_preprocess_data(replace_names=["x", "ymin", "ymax", "colors"],
                       label_namer="x")
     def vlines(self, x, ymin, ymax, colors=None, linestyles='solid',
-               label='', **kwargs):
+               label='', transform=None, **kwargs):
         """
         Plot vertical lines at each *x* from *ymin* to *ymax*.
 
@@ -1173,18 +1173,30 @@ def vlines(self, x, ymin, ymax, colors=None, linestyles='solid',
 
         lines = mcoll.LineCollection(masked_verts, colors=colors,
                                      linestyles=linestyles, label=label)
+        if transform is not None:
+            lines.set_transform(transform)
         self.add_collection(lines, autolim=False)
+        self._unstale_viewLim()
         lines._internal_update(kwargs)
 
         if len(x) > 0:
             # Extreme values of x/ymin/ymax.  Using masked_verts here handles
             # the case of x being a masked *object* array (as can be generated
             # e.g. by errorbar()), which would make nanmin/nanmax stumble.
-            minx = np.nanmin(masked_verts[..., 0])
-            maxx = np.nanmax(masked_verts[..., 0])
-            miny = np.nanmin(masked_verts[..., 1])
-            maxy = np.nanmax(masked_verts[..., 1])
-            corners = (minx, miny), (maxx, maxy)
+            if self.name == "polar":
+                minx = np.nanmin(masked_verts[..., 0])
+                maxx = np.nanmax(masked_verts[..., 0])
+                miny = np.nanmin(masked_verts[..., 1])
+                maxy = np.nanmax(masked_verts[..., 1])
+                corners = (minx, miny), (maxx, maxy)
+            else:
+                datalim = lines.get_datalim(self.transData)
+                minx = np.nanmin(datalim.xmin)
+                maxx = np.nanmax(datalim.xmax)
+                miny = np.nanmin(datalim.ymin)
+                maxy = np.nanmax(datalim.ymax)
+                corners = (minx, miny), (maxx, maxy)
+
             self.update_datalim(corners)
             self._request_autoscale_view()
 
diff --git a/lib/matplotlib/tests/baseline_images/test_axes/vlines_blended_transform.png b/lib/matplotlib/tests/baseline_images/test_axes/vlines_blended_transform.png
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -4938,6 +4938,17 @@ def test_lines_with_colors(fig_test, fig_ref, data):
                                         colors=expect_color, linewidth=5)
 
 
+@image_comparison(['vlines_blended_transform'],
+                  extensions=['png'], style='mpl20')
+def test_vlines_blended_transform():
+    t = np.arange(5.0, 10.0, 0.1)
+    s = np.exp(-t) + np.sin(2 * np.pi * t) + 10
+    vax = plt.figure(figsize=(12, 6)).gca()
+    vax.plot(t, s, '^')
+    vax.vlines([6, 7], ymin=0, ymax=0.15, transform=vax.get_xaxis_transform(),
+               colors='r')
+
+
 @image_comparison(['step_linestyle', 'step_linestyle'], remove_text=True)
 def test_step_linestyle():
     x = y = np.arange(10)
