Merge pull request #1103 from efiring/colorbar_lines_bug

mdboom · mdboom · commit 2a25fe8dfe95 · 2012-08-17T14:21:11.000-07:00
colorbar: correct error introduced in commit 089024; closes #1102
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -212,7 +212,8 @@ class ColorbarBase(cm.ScalarMappable):
             the Axes instance in which the colorbar is drawn
 
         :attr:`lines`
-            a LineCollection if lines were drawn, otherwise None
+            a list of LineCollection if lines were drawn, otherwise
+            an empty list
 
         :attr:`dividers`
             a LineCollection if *drawedges* is True, otherwise None
@@ -495,8 +496,9 @@ def add_lines(self, levels, colors, linewidths, erase=True):
         col = collections.LineCollection(xy, linewidths=linewidths)
 
         if erase and self.lines:
-            for lc in self.lines.pop():
+            for lc in self.lines:
                 lc.remove()
+            self.lines = []
         self.lines.append(col)
         col.set_color(colors)
         self.ax.add_collection(col)
