Markers with fillstyle 'none' should return False for is_filled()

timhoffm · timhoffm · commit 2a3707d9c347 · 2020-06-04T21:55:02.000+02:00
diff --git a/lib/matplotlib/markers.py b/lib/matplotlib/markers.py
@@ -232,7 +232,10 @@ def _recache(self):
         self._snap_threshold = None
         self._joinstyle = 'round'
         self._capstyle = 'butt'
-        self._filled = True
+        # Initial guess: Assume the marker is filled unless the fillstyle is
+        # set to 'none'. The marker function will override this for unfilled
+        # markers.
+        self._filled = self._fillstyle != 'none'
         self._marker_function()
 
     def __bool__(self):
diff --git a/lib/matplotlib/tests/test_marker.py b/lib/matplotlib/tests/test_marker.py
@@ -7,6 +7,12 @@
 import pytest
 
 
+def test_marker_fillstyle():
+    marker_style = markers.MarkerStyle(marker='o', fillstyle='none')
+    assert marker_style.get_fillstyle() == 'none'
+    assert not marker_style.is_filled()
+
+
 def test_markers_valid():
     marker_style = markers.MarkerStyle()
     mrk_array = np.array([[-0.5, 0],
