Change colour of Tk toolbar icons on dark backgrounds

daniilS · timhoffm · daniilS · commit 2b03be1bb5c1 · 2022-01-11T23:21:12.000Z
Co-Authored-By: Tim Hoffmann &lt;2836374+timhoffm@users.noreply.github.com&gt;
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -634,6 +634,16 @@ def set_cursor(self, cursor):
         except tkinter.TclError:
             pass
 
+    def _is_dark(self, button, color):
+        # `winfo_rgb` returns an (r, g, b) tuple in the range from 0 to 65535
+        return max(button.winfo_rgb(button.cget(color))) < 65535 / 2
+
+    def _recolor_icon(self, image, color):
+        image_data = np.asarray(image).copy()
+        black_mask = (image_data[..., :3] == 0).all(axis=-1)
+        image_data[black_mask, :3] = color
+        return Image.fromarray(image_data, mode="RGBA")
+
     def _set_image_for_button(self, button):
         """
         Set the image for a button based on its pixel size.
@@ -653,8 +663,30 @@ def _set_image_for_button(self, button):
         with Image.open(path_large if (size > 24 and path_large.exists())
                         else path_regular) as im:
             image = ImageTk.PhotoImage(im.resize((size, size)), master=self)
-        button.configure(image=image, height='18p', width='18p')
-        button._ntimage = image  # Prevent garbage collection.
+            button._ntimage = image
+
+            # create a version of the icon with the button's text color
+            foreground = (255 / 65535) * np.array(
+                button.winfo_rgb(button.cget("foreground")))
+            im_alt = self._recolor_icon(im, foreground)
+            image_alt = ImageTk.PhotoImage(
+                im_alt.resize((size, size)), master=self)
+            button._ntimage_alt = image_alt
+
+        if (self._is_dark(button, "background")):
+            button.configure(image=image_alt)
+        else:
+            button.configure(image=image)
+        if (
+            isinstance(button, tk.Checkbutton)
+            and button.cget("selectcolor") != ""
+        ):
+            if (self._is_dark(button, "selectcolor")):
+                button.configure(selectimage=image_alt)
+            else:
+                button.configure(selectimage=image)
+
+        button.configure(height='18p', width='18p')
 
     def _Button(self, text, image_file, toggle, command):
         if not toggle:
diff --git a/lib/matplotlib/tests/test_backend_tk.py b/lib/matplotlib/tests/test_backend_tk.py
@@ -185,3 +185,42 @@ class Toolbar(NavigationToolbar2Tk):
     print("success")
     Toolbar(fig.canvas, fig.canvas.manager.window)  # This should not raise.
     print("success")
+
+
+@pytest.mark.backend('TkAgg', skip_on_importerror=True)
+@_isolated_tk_test(success_count=2)
+def test_embedding():  # pragma: no cover
+    import tkinter as tk
+    from matplotlib.backends.backend_tkagg import (
+        FigureCanvasTkAgg, NavigationToolbar2Tk)
+    from matplotlib.backend_bases import key_press_handler
+    from matplotlib.figure import Figure
+
+    root = tk.Tk()
+
+    def test_figure(master):
+        fig = Figure()
+        ax = fig.add_subplot()
+        ax.plot([1, 2, 3])
+
+        canvas = FigureCanvasTkAgg(fig, master=master)
+        canvas.draw()
+        canvas.mpl_connect("key_press_event", key_press_handler)
+        canvas.get_tk_widget().pack(expand=True, fill="both")
+
+        toolbar = NavigationToolbar2Tk(canvas, master, pack_toolbar=False)
+        toolbar.pack(expand=True, fill="x")
+
+        canvas.get_tk_widget().forget()
+        toolbar.forget()
+
+    test_figure(root)
+    print("success")
+
+    # Test with a dark button color. Doesn't actually check whether the icon
+    # color becomes lighter, just that the code doesn't break.
+
+    root.tk_setPalette(background="sky blue", selectColor="midnight blue",
+                       foreground="white")
+    test_figure(root)
+    print("success")
