Merge pull request #11076 from anntzer/dont-pollute-root-dir

jklymak · web-flow · commit 2d41a8decdc9 · 2018-04-18T07:41:53.000-07:00
Don't create texput.{aux,log} in rootdir everytime tests are run.
diff --git a/.gitignore b/.gitignore
@@ -74,8 +74,6 @@ examples/*/*.eps
 examples/*/*.svgz
 examples/tests/*
 !examples/tests/backend_driver.py
-texput.log
-texput.aux
 result_images
 
 # Nose/Pytest generated files #
diff --git a/lib/matplotlib/tests/test_backend_pgf.py b/lib/matplotlib/tests/test_backend_pgf.py
@@ -1,6 +1,8 @@
 import os
+from pathlib import Path
 import shutil
 import subprocess
+from tempfile import TemporaryDirectory
 
 import numpy as np
 import pytest
@@ -15,23 +17,23 @@
 
 
 def check_for(texsystem):
-    header = """
-    \\documentclass{minimal}
-    \\usepackage{pgf}
-    \\begin{document}
-    \\typeout{pgfversion=\\pgfversion}
-    \\makeatletter
-    \\@@end
-    """
-    try:
-        latex = subprocess.Popen([str(texsystem), "-halt-on-error"],
-                                 stdin=subprocess.PIPE,
-                                 stdout=subprocess.PIPE)
-        stdout, stderr = latex.communicate(header.encode("utf8"))
-    except OSError:
-        return False
-
-    return latex.returncode == 0
+    with TemporaryDirectory() as tmpdir:
+        tex_path = Path(tmpdir, "test.tex")
+        tex_path.write_text(r"""
+            \documentclass{minimal}
+            \usepackage{pgf}
+            \begin{document}
+            \typeout{pgfversion=\pgfversion}
+            \makeatletter
+            \@@end
+        """)
+        try:
+            subprocess.check_call(
+                [texsystem, "-halt-on-error", str(tex_path)], cwd=tmpdir,
+                stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+        except (OSError, subprocess.CalledProcessError):
+            return False
+        return True
 
 
 needs_xelatex = pytest.mark.skipif(not check_for('xelatex'),
@@ -97,7 +99,6 @@ def test_xelatex():
 @image_comparison(baseline_images=['pgf_pdflatex'], extensions=['pdf'],
                   style='default')
 def test_pdflatex():
-    import os
     if os.environ.get('APPVEYOR', False):
         pytest.xfail("pdflatex test does not work on appveyor due to missing "
                      "LaTeX fonts")
