Yet another iteration on the version checking in backend_wx

efiring · efiring · commit 3209a7720c9c · 2009-07-11T18:06:54.000Z
svn path=/trunk/matplotlib/; revision=7256
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py
@@ -116,28 +116,31 @@
     raise ImportError(missingwx)
 
 # Some early versions of wxversion lack AlreadyImportedError.
-if hasattr(wxversion, 'AlreadyImportedError'):
-    try:
-        wxversion.ensureMinimal('2.8')
-    except wxversion.AlreadyImportedError:
-        pass
-else:
-    warnings.warn(
-            "Update your wxversion.py to one including AlreadyImportedError")
-    try:
-        wxversion.ensureMinimal('2.8')
-    except wxversion.VersionError:
-        pass
+# It was added around 2.8.4?
+try:
+    _wx_ensure_failed = wxversion.AlreadyImportedError
+except AttributeError:
+    _wx_ensure_failed = wxversion.VersionError
+
+try:
+    wxversion.ensureMinimal('2.8')
+except _wx_ensure_failed:
+    pass
+# We don't really want to pass in case of VersionError, but when
+# AlreadyImportedError is not available, we have to.
 
 try:
     import wx
     backend_version = wx.VERSION_STRING
 except ImportError:
     raise ImportError(missingwx)
 
-# Extra version check in case  wxversion is broken:
+# Extra version check in case wxversion lacks AlreadyImportedError;
+# then VersionError might have been raised and ignored when
+# there really *is* a problem with the version.
 major, minor = [int(n) for n in backend_version.split('.')[:2]]
 if major < 2 or (major < 3 and minor < 8):
+    print " wxPython version %s was imported." % backend_version
     raise ImportError(missingwx)
 
 
