Use strict equality in JS files.

QuLogic · QuLogic · commit 33d496b37f07 · 2020-04-04T01:22:03.000-04:00
diff --git a/lib/matplotlib/backends/web_backend/js/mpl.js b/lib/matplotlib/backends/web_backend/js/mpl.js
@@ -22,7 +22,7 @@ mpl.figure = function (figure_id, websocket, ondownload, parent_element) {
 
     this.ws = websocket;
 
-    this.supports_binary = this.ws.binaryType != undefined;
+    this.supports_binary = this.ws.binaryType !== undefined;
 
     if (!this.supports_binary) {
         var warnings = document.getElementById('mpl-warnings');
@@ -62,14 +62,14 @@ mpl.figure = function (figure_id, websocket, ondownload, parent_element) {
     this.ws.onopen = function () {
         fig.send_message('supports_binary', { value: fig.supports_binary });
         fig.send_message('send_image_mode', {});
-        if (mpl.ratio != 1) {
+        if (mpl.ratio !== 1) {
             fig.send_message('set_dpi_ratio', { dpi_ratio: mpl.ratio });
         }
         fig.send_message('refresh', {});
     };
 
     this.imageObj.onload = function () {
-        if (fig.image_mode == 'full') {
+        if (fig.image_mode === 'full') {
             // Full images could contain transparency (where diff images
             // almost always do), so we need to clear the canvas so that
             // there is no ghosting.
@@ -336,7 +336,7 @@ mpl.figure.prototype.handle_save = function (fig, _msg) {
 
 mpl.figure.prototype.handle_resize = function (fig, msg) {
     var size = msg['size'];
-    if (size[0] != fig.canvas.width || size[1] != fig.canvas.height) {
+    if (size[0] !== fig.canvas.width || size[1] !== fig.canvas.height) {
         fig._resize_canvas(size[0], size[1]);
         fig.send_message('refresh', {});
     }
@@ -434,7 +434,7 @@ mpl.figure.prototype._make_on_message_function = function (fig) {
             return;
         } else if (
             typeof evt.data === 'string' &&
-            evt.data.slice(0, 21) == 'data:image/png;base64'
+            evt.data.slice(0, 21) === 'data:image/png;base64'
         ) {
             fig.imageObj.src = evt.data;
             fig.updated_canvas_event();
@@ -485,7 +485,7 @@ mpl.findpos = function (e) {
     } else if (e.srcElement) {
         targ = e.srcElement;
     }
-    if (targ.nodeType == 3) {
+    if (targ.nodeType === 3) {
         // defeat Safari bug
         targ = targ.parentNode;
     }
@@ -546,25 +546,25 @@ mpl.figure.prototype._key_event_extra = function (_event, _name) {
 
 mpl.figure.prototype.key_event = function (event, name) {
     // Prevent repeat events
-    if (name == 'key_press') {
+    if (name === 'key_press') {
         if (event.which === this._key) {
             return;
         } else {
             this._key = event.which;
         }
     }
-    if (name == 'key_release') {
+    if (name === 'key_release') {
         this._key = null;
     }
 
     var value = '';
-    if (event.ctrlKey && event.which != 17) {
+    if (event.ctrlKey && event.which !== 17) {
         value += 'ctrl+';
     }
-    if (event.altKey && event.which != 18) {
+    if (event.altKey && event.which !== 18) {
         value += 'alt+';
     }
-    if (event.shiftKey && event.which != 16) {
+    if (event.shiftKey && event.which !== 16) {
         value += 'shift+';
     }
 
@@ -578,7 +578,7 @@ mpl.figure.prototype.key_event = function (event, name) {
 };
 
 mpl.figure.prototype.toolbar_button_onclick = function (name) {
-    if (name == 'download') {
+    if (name === 'download') {
         this.handle_save(this, null);
     } else {
         this.send_message('toolbar_button', { name: name });
diff --git a/lib/matplotlib/backends/web_backend/js/nbagg_mpl.js b/lib/matplotlib/backends/web_backend/js/nbagg_mpl.js
@@ -179,7 +179,7 @@ mpl.figure.prototype._key_event_extra = function (event, _name) {
     }
 
     // Check for shift+enter
-    if (event.shiftKey && event.which == 13) {
+    if (event.shiftKey && event.which === 13) {
         this.canvas_div.blur();
         // select the cell after this one
         var index = IPython.notebook.find_cell_index(this.cell_info[0]);
@@ -207,7 +207,7 @@ mpl.find_output_cell = function (html_output) {
                     // IPython >= 3 moved mimebundle to data attribute of output
                     data = data.data;
                 }
-                if (data['text/html'] == html_output) {
+                if (data['text/html'] === html_output) {
                     return [cell, data, j];
                 }
             }
@@ -217,7 +217,7 @@ mpl.find_output_cell = function (html_output) {
 
 // Register the function which deals with the matplotlib target/channel.
 // The kernel may be null if the page has been refreshed.
-if (IPython.notebook.kernel != null) {
+if (IPython.notebook.kernel !== null) {
     IPython.notebook.kernel.comm_manager.register_target(
         'matplotlib',
         mpl.mpl_figure_comm

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ mpl.figure.prototype._key_event_extra = function (event, _name) {`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`// Check for shift+enter`
`182`		`- if (event.shiftKey && event.which == 13) {`
	`182`	`+ if (event.shiftKey && event.which === 13) {`
`183`	`183`	`this.canvas_div.blur();`
`184`	`184`	`// select the cell after this one`
`185`	`185`	`var index = IPython.notebook.find_cell_index(this.cell_info[0]);`
`@@ -207,7 +207,7 @@ mpl.find_output_cell = function (html_output) {`
`207`	`207`	`// IPython >= 3 moved mimebundle to data attribute of output`
`208`	`208`	`data = data.data;`
`209`	`209`	`}`
`210`		`- if (data['text/html'] == html_output) {`
	`210`	`+ if (data['text/html'] === html_output) {`
`211`	`211`	`return [cell, data, j];`
`212`	`212`	`}`
`213`	`213`	`}`
`@@ -217,7 +217,7 @@ mpl.find_output_cell = function (html_output) {`
`217`	`217`
`218`	`218`	`// Register the function which deals with the matplotlib target/channel.`
`219`	`219`	`// The kernel may be null if the page has been refreshed.`
`220`		`-if (IPython.notebook.kernel != null) {`
	`220`	`+if (IPython.notebook.kernel !== null) {`
`221`	`221`	`IPython.notebook.kernel.comm_manager.register_target(`
`222`	`222`	`'matplotlib',`
`223`	`223`	`mpl.mpl_figure_comm`