Support lualatex < 0.85

maxnoe · maxnoe · commit 3496bd4ce9ba · 2018-02-23T11:30:28.000+01:00
diff --git a/lib/matplotlib/backends/backend_pgf.py b/lib/matplotlib/backends/backend_pgf.py
@@ -51,13 +51,31 @@
     except:
         warnings.warn('error getting fonts from fc-list', UserWarning)
 
+
+luatex_version_re = re.compile(
+    'This is LuaTeX, Version (?:beta-)?([0-9]+)\.([0-9]+)\.([0-9]+)'
+)
+
+
 def get_texcommand():
     """Get chosen TeX system from rc."""
     texsystem_options = ["xelatex", "lualatex", "pdflatex"]
     texsystem = rcParams["pgf.texsystem"]
     return texsystem if texsystem in texsystem_options else "xelatex"
 
 
+def get_lualatex_version():
+    """Get version of luatex"""
+    output = check_output(['lualatex', '--version'])
+    return parse_lualatex_version(output.decode())
+
+
+def parse_lualatex_version(output):
+    '''parse the lualatex version from the output of `lualatex --version`'''
+    match = luatex_version_re.match(output)
+    return tuple(map(int, match.groups()))
+
+
 def get_fontspec():
     """Build fontspec preamble from rc."""
     latex_fontspec = []
@@ -1181,17 +1199,16 @@ def savefig(self, figure=None, **kwargs):
                 self._write_header(*figure.get_size_inches())
             else:
                 if get_texcommand() == 'lualatex':
-                    self._file.write(
-                        r'\newpage\pagewidth={}in\pageheight={}in%'.format(
-                            *figure.get_size_inches()
-                        ).encode('utf-8') + b'\n'
-                    )
+                    if get_lualatex_version() > (0, 85, 0):
+                        np = r'\newpage\pagewidth={}in\pageheight={}in%'
+                    else:
+                        np = r'\newpage\pdfpagewidth={}in\pdfpageheight={}in%'
                 else:
-                    self._file.write(
-                        r'\newpage\pdfpagewidth={}in\pdfpageheight={}in%'.format(
-                            *figure.get_size_inches()
-                        ).encode('utf-8') + b'\n'
-                    )
+                    np = r'\newpage\pdfpagewidth={}in\pdfpageheight={}in%'
+                self._file.write(np.format(
+                        *figure.get_size_inches()
+                    ).encode('utf-8') + b'\n'
+                )
             figure.savefig(self._file, format="pgf", **kwargs)
             self._n_figures += 1
         finally:
diff --git a/lib/matplotlib/tests/test_backend_pgf.py b/lib/matplotlib/tests/test_backend_pgf.py
@@ -276,3 +276,40 @@ def test_pdf_pages_lualatex():
         pdf.savefig(fig)
 
         assert pdf.get_pagecount() == 2
+
+
+@needs_lualatex
+def test_luatex_version():
+    from matplotlib.backends.backend_pgf import parse_lualatex_version
+    from matplotlib.backends.backend_pgf import get_lualatex_version
+
+    v1 = '''This is LuaTeX, Version 1.0.4 (TeX Live 2017)
+
+Execute  'luatex --credits'  for credits and version details.
+
+There is NO warranty. Redistribution of this software is covered by
+the terms of the GNU General Public License, version 2 or (at your option)
+any later version. For more information about these matters, see the file
+named COPYING and the LuaTeX source.
+
+LuaTeX is Copyright 2017 Taco Hoekwater and the LuaTeX Team.
+'''
+
+    v2 = '''This is LuaTeX, Version beta-0.76.0-2015112019  (TeX Live 2013) (rev 4627)
+
+Execute  'luatex --credits'  for credits and version details.
+
+There is NO warranty. Redistribution of this software is covered by
+the terms of the GNU General Public License, version 2 or (at your option)
+any later version. For more information about these matters, see the file
+named COPYING and the LuaTeX source.
+
+Copyright 2013 Taco Hoekwater, the LuaTeX Team.
+'''
+
+    assert parse_lualatex_version(v1) == (1, 0, 4)
+    assert parse_lualatex_version(v2) == (0, 76, 0)
+
+    # just test if it is successfull
+    version = get_lualatex_version()
+    assert len(version) == 3
