Reuse subprocess_run_helper in test_pylab_integration.

anntzer · anntzer · commit 353aaf9a4839 · 2022-05-23T15:48:05.000+02:00
It's basically here for that purpose...
diff --git a/lib/matplotlib/testing/__init__.py b/lib/matplotlib/testing/__init__.py
@@ -52,7 +52,7 @@ def setup():
 
 def subprocess_run_helper(func, *args, timeout, **extra_env):
     """
-    Run a function in a sub-process
+    Run a function in a sub-process.
 
     Parameters
     ----------
@@ -61,12 +61,10 @@ def subprocess_run_helper(func, *args, timeout, **extra_env):
 
     *args : str
         Any additional command line arguments to be passed in
-        the first argument to subprocess.run
+        the first argument to `subprocess.run`.
 
     **extra_env : Dict[str, str]
-        Any additional envromental variables to be set for
-        the subprocess.
-
+        Any additional environment variables to be set for the subprocess.
     """
     target = func.__name__
     module = func.__module__
diff --git a/lib/matplotlib/tests/test_pyplot.py b/lib/matplotlib/tests/test_pyplot.py
@@ -371,23 +371,13 @@ def test_set_current_axes_on_subfigure():
 
 
 def test_pylab_integration():
-    pytest.importorskip("IPython")
-    subprocess.run(
-        [
-            sys.executable,
-            "-m",
-            "IPython",
-            "--pylab",
-            "-c",
-            ";".join((
-                "import matplotlib.pyplot as plt",
-                "assert plt._REPL_DISPLAYHOOK == plt._ReplDisplayHook.IPYTHON",
-            )),
-        ],
-        env={**os.environ, "SOURCE_DATE_EPOCH": "0"},
+    mpl.testing.subprocess_run_helper(
+        pytest.importorskip("IPython").start_ipython,
+        "--pylab",
+        "-c",
+        ";".join((
+            "import matplotlib.pyplot as plt",
+            "assert plt._REPL_DISPLAYHOOK == plt._ReplDisplayHook.IPYTHON",
+        )),
         timeout=60,
-        check=True,
-        stdout=subprocess.PIPE,
-        stderr=subprocess.PIPE,
-        universal_newlines=True,
     )
