Merge pull request #4041 from dopplershift/anim-windows

tacaswell · tacaswell · commit 36a7a21fb9b6 · 2015-01-29T00:00:59.000-05:00
BUG : Prevent Windows from opening command prompt
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -23,6 +23,7 @@
 import six
 from six.moves import xrange, zip
 
+import platform
 import sys
 import itertools
 import contextlib
@@ -31,6 +32,16 @@
 from matplotlib import verbose
 from matplotlib import rcParams
 
+# Process creation flag for subprocess to prevent it raising a terminal
+# window. See for example:
+# https://stackoverflow.com/questions/24130623/using-python-subprocess-popen-cant-prevent-exe-stopped-working-prompt
+if platform.system() == 'Windows':
+    CREATE_NO_WINDOW = 0x08000000
+    subprocess_creation_flags = CREATE_NO_WINDOW
+else:
+    # Apparently None won't work here
+    subprocess_creation_flags = 0
+
 # Other potential writing methods:
 # * http://pymedia.org/
 # * libmng (produces swf) python wrappers: https://github.com/libming/libming
@@ -189,7 +200,8 @@ def _run(self):
                        ' '.join(command))
         self._proc = subprocess.Popen(command, shell=False,
                                       stdout=output, stderr=output,
-                                      stdin=subprocess.PIPE)
+                                      stdin=subprocess.PIPE,
+                                      creationflags=subprocess_creation_flags)
 
     def finish(self):
         'Finish any processing for writing the movie.'
@@ -250,7 +262,8 @@ def isAvailable(cls):
             p = subprocess.Popen(cls.bin_path(),
                              shell=False,
                              stdout=subprocess.PIPE,
-                             stderr=subprocess.PIPE)
+                             stderr=subprocess.PIPE,
+                             creationflags=subprocess_creation_flags)
             p.communicate()
             return True
         except OSError:
