BUG: Fix some incorrect reference handling

dopplershift · dopplershift · commit 3a5c909800d7 · 2017-11-01T21:26:28.000-06:00
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -2867,7 +2867,11 @@ static void timer_callback(CFRunLoopTimerRef timer, void* info)
     PyObject* method = info;
     PyGILState_STATE gstate = PyGILState_Ensure();
     PyObject* result = PyObject_CallFunction(method, NULL);
-    if (result==NULL) PyErr_Print();
+    if (result) {
+        Py_DECREF(result);
+    } else {
+        PyErr_Print();
+    }
     PyGILState_Release(gstate);
 }
 
@@ -2923,6 +2927,7 @@ static void context_cleanup(const void* info)
             PyErr_SetString(PyExc_ValueError, "Cannot interpret _single attribute as True of False");
             return NULL;
     }
+    Py_DECREF(attribute);
     attribute = PyObject_GetAttrString((PyObject*)self, "_on_timer");
     if (attribute==NULL)
     {
@@ -2942,10 +2947,10 @@ static void context_cleanup(const void* info)
                                  timer_callback,
                                  &context);
     if (!timer) {
+        Py_DECREF(attribute);
         PyErr_SetString(PyExc_RuntimeError, "Failed to create timer");
         return NULL;
     }
-    Py_INCREF(attribute);
     if (self->timer) {
         CFRunLoopTimerInvalidate(self->timer);
         CFRelease(self->timer);
