BUG : bbox with any nan points can not overlap

tacaswell · tacaswell · commit 3ab6b24c676d · 2015-04-04T22:03:37.000-04:00
Fixes #4309
diff --git a/lib/matplotlib/tests/test_transforms.py b/lib/matplotlib/tests/test_transforms.py
@@ -9,7 +9,7 @@
 from nose.tools import assert_equal, assert_raises
 import numpy.testing as np_test
 from numpy.testing import assert_almost_equal, assert_array_equal
-from matplotlib.transforms import Affine2D, BlendedGenericTransform
+from matplotlib.transforms import Affine2D, BlendedGenericTransform, Bbox
 from matplotlib.path import Path
 from matplotlib.scale import LogScale
 from matplotlib.testing.decorators import cleanup, image_comparison
@@ -501,6 +501,12 @@ def test_log_transform():
     ax.set_yscale('log')
     ax.transData.transform((1,1))
 
+@cleanup
+def test_nan_overlap():
+    a = Bbox([[0, 0], [1, 1]])
+    b = Bbox([[0, 0], [1, np.nan]])
+    assert not a.overlaps(b)
+
 
 if __name__=='__main__':
     import nose
diff --git a/lib/matplotlib/transforms.py b/lib/matplotlib/transforms.py
@@ -447,6 +447,8 @@ def overlaps(self, other):
         """
         ax1, ay1, ax2, ay2 = self._get_extents()
         bx1, by1, bx2, by2 = other._get_extents()
+        if any(np.isnan(v) for v in [ax1, ay1, ax2, ay2, bx1, by1, bx2, by2]):
+            return False
 
         if ax2 < ax1:
             ax2, ax1 = ax1, ax2
