TST: add smoketest for ordereddict legend handles

jklymak · jklymak · commit 3d65ca1afcec · 2018-01-16T15:51:09.000-08:00
diff --git a/lib/matplotlib/legend.py b/lib/matplotlib/legend.py
@@ -599,7 +599,7 @@ def __init__(self, parent, handles, labels,
             else:
                 _lab.append(label)
                 _hand.append(handle)
-        label, handle = _lab, _hand
+        labels, handles = _lab, _hand
 
         handles = list(handles)
         if len(handles) < 2:
diff --git a/lib/matplotlib/tests/test_legend.py b/lib/matplotlib/tests/test_legend.py
@@ -5,6 +5,7 @@
     from unittest import mock
 except ImportError:
     import mock
+import collections
 import numpy as np
 import pytest
 
@@ -53,6 +54,23 @@ def test_legend_kwdocstrings():
     assert stleg == stfig
 
 
+def test_legend_ordereddict():
+    # smoketest that ordereddict inputs work...
+
+    X = np.random.randn(10)
+    Y = np.random.randn(10)
+    labels = ['a'] * 5 + ['b'] * 5
+    colors = ['r'] * 5 + ['g'] * 5
+
+    fig, ax = plt.subplots()
+    for x, y, label, color in zip(X, Y, labels, colors):
+        ax.scatter(x, y, label=label, c=color)
+
+    handles, labels = ax.get_legend_handles_labels()
+    legend = collections.OrderedDict(zip(labels, handles))
+    ax.legend(legend.values(), legend.keys(), loc=6, bbox_to_anchor=(1, .5))
+
+
 @image_comparison(baseline_images=['legend_auto1'], remove_text=True)
 def test_legend_auto1():
     'Test automatic legend placement'
