Change layout of test_triager to avoid cropping images.

anntzer · anntzer · commit 3f2a3fcde8a4 · 2019-09-12T22:49:11.000+02:00
The previous test triager would crop test images because the 800/500
aspect ratio of the main widget does not match the 6.4:4.8 aspect ratio
of the test images.  Change the main widget to have size 800x600, and
move the thumbnails to the side so that the whole thing still fits in a
1600x900 display.
diff --git a/tools/triage_tests.py b/tools/triage_tests.py
@@ -68,7 +68,7 @@ def __init__(self, parent, index, name):
         self.image = QtWidgets.QLabel()
         self.image.setAlignment(QtCore.Qt.AlignHCenter |
                                 QtCore.Qt.AlignVCenter)
-        self.image.setMinimumSize(800/3, 500/3)
+        self.image.setMinimumSize(800/3, 600/3)
         layout.addWidget(self.image)
         self.setLayout(layout)
 
@@ -124,21 +124,21 @@ def __init__(self, entries):
         for entry in entries:
             self.filelist.addItem(entry.display)
 
-        images_box = QtWidgets.QWidget()
-        images_layout = QtWidgets.QVBoxLayout()
         thumbnails_box = QtWidgets.QWidget()
-        thumbnails_layout = QtWidgets.QHBoxLayout()
+        thumbnails_layout = QtWidgets.QVBoxLayout()
         self.thumbnails = []
         for i, name in enumerate(('test', 'expected', 'diff')):
             thumbnail = Thumbnail(self, i, name)
             thumbnails_layout.addWidget(thumbnail)
             self.thumbnails.append(thumbnail)
         thumbnails_box.setLayout(thumbnails_layout)
+
+        images_layout = QtWidgets.QVBoxLayout()
+        images_box = QtWidgets.QWidget()
         self.image_display = QtWidgets.QLabel()
         self.image_display.setAlignment(QtCore.Qt.AlignHCenter |
                                         QtCore.Qt.AlignVCenter)
-        self.image_display.setMinimumSize(800, 500)
-        images_layout.addWidget(thumbnails_box, 3)
+        self.image_display.setMinimumSize(800, 600)
         images_layout.addWidget(self.image_display, 6)
         images_box.setLayout(images_layout)
 
@@ -154,8 +154,9 @@ def __init__(self, entries):
         images_layout.addWidget(buttons_box)
 
         main_layout = QtWidgets.QHBoxLayout()
-        main_layout.addWidget(self.filelist, 3)
-        main_layout.addWidget(images_box, 6)
+        main_layout.addWidget(self.filelist, 1)
+        main_layout.addWidget(thumbnails_box, 1)
+        main_layout.addWidget(images_box, 3)
 
         self.setLayout(main_layout)
 
