Deprecate axis_artist.BezierPath.

anntzer · anntzer · commit 3fa8f1e9f295 · 2019-07-15T11:28:26.000+02:00
Throughout the library the advice to draw an arbitrary Path object is to
use PathPatch; there's no reason to do differently with a one-off class
in axisartist.

Technically that's an API break because the type of AxisArtist.line
changed, but most common APIs do overlap (e.g. `set_color`, which is
exercised by the tests) so I'm not going to bother with a deprecation
period which would be quite painful (likely involving a global rcParam
controlling the switch from the old API to the new one).
diff --git a/doc/api/next_api_changes/2019-07-15-AL.rst b/doc/api/next_api_changes/2019-07-15-AL.rst
@@ -0,0 +1,8 @@
+API changes and deprecations
+````````````````````````````
+
+``axisartist.axis_artist.BezierPath`` is deprecated (use `.patches.PathPatch`
+to draw arbitrary Paths).
+
+``AxisArtist.line`` is now a `.patches.PathPatch` instance instead of a
+``BezierPath`` instance.
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -941,6 +941,9 @@ def __init__(self, path, **kwargs):
     def get_path(self):
         return self._path
 
+    def set_path(self, path):
+        self._path = path
+
 
 class Polygon(Patch):
     """
diff --git a/lib/mpl_toolkits/axisartist/axis_artist.py b/lib/mpl_toolkits/axisartist/axis_artist.py
@@ -96,13 +96,15 @@
 from matplotlib.artist import Artist
 from matplotlib.collections import LineCollection
 from matplotlib.lines import Line2D
+from matplotlib.patches import PathPatch
 from matplotlib.path import Path
 from matplotlib.transforms import (
     Affine2D, Bbox, IdentityTransform, ScaledTranslation, TransformedPath)
 
 from .axisline_style import AxislineStyle
 
 
+@cbook.deprecated("3.2", alternative="matplotlib.patches.PathPatch")
 class BezierPath(Line2D):
 
     def __init__(self, path, *args, **kwargs):
@@ -926,10 +928,13 @@ def _init_line(self):
 
         axisline_style = self.get_axisline_style()
         if axisline_style is None:
-            self.line = BezierPath(
+            self.line = PathPatch(
                 self._axis_artist_helper.get_line(self.axes),
                 color=rcParams['axes.edgecolor'],
+                fill=False,
                 linewidth=rcParams['axes.linewidth'],
+                capstyle=rcParams['lines.solid_capstyle'],
+                joinstyle=rcParams['lines.solid_joinstyle'],
                 transform=tran)
         else:
             self.line = axisline_style(self, transform=tran)
