FIX: Explicitly clean up temporary files in HTMLWriter

tacaswell · tacaswell · commit 400ea30016ba · 2020-12-16T16:26:11.000-05:00
- HTMLWriter inherits from FileMovieWriter.
- FileMovieWriter create a non-context manager TemporayDirectory on
  init.
- The TemporayDirectory is cleaned up in the cleaup method of
  FileMovieWriter.
- However this method (and its call chain through finish) try to
  either call a subprocess to merge a bunch of single-frame files into
  a movie (not relevant) or to clean up such a process (not relevant).
- The least disruptive fix is to duplicate the file clean up code.
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -891,6 +891,22 @@ def finish(self):
                                              interval=interval,
                                              **mode_dict))
 
+        # duplicate the temporary file clean up logic from
+        # FileMovieWriter.cleanup.  We can not call the inherited
+        # versions of finished or cleanup because both assume that
+        # there is a subprocess that we either need to call to merge
+        # many frames together or that there is a subprocess call that
+        # we need to clean up.
+        if self._tmpdir:
+            _log.debug('MovieWriter: clearing temporary path=%s', self._tmpdir)
+            self._tmpdir.cleanup()
+        else:
+            if self._clear_temp:
+                _log.debug('MovieWriter: clearing temporary paths=%s',
+                           self._temp_paths)
+                for path in self._temp_paths:
+                    path.unlink()
+
 
 class Animation:
     """
