Merge pull request #7172 from tacaswell/api_bar_where

efiring · web-flow · commit 422e78a17259 · 2016-09-25T07:31:55.000-10:00
API: change default 'align' for bar and barh
diff --git a/doc/users/dflt_style_changes.rst b/doc/users/dflt_style_changes.rst
@@ -500,7 +500,7 @@ default.  The default face color is now ``'C0'`` instead of ``'b'``.
        with rc_context(rc=rcparams):
            ax_top.pie(fracs, labels=labels)
            ax_top.set_aspect('equal')
-           ax_mid.bar(range(len(fracs)), fracs, tick_label=labels, align='center')
+           ax_mid.bar(range(len(fracs)), fracs, tick_label=labels)
            plt.setp(ax_mid.get_xticklabels(), rotation=-45)
            grid = np.mgrid[0.2:0.8:3j, 0.2:0.8:3j].reshape(2, -1).T
 
@@ -529,6 +529,39 @@ or by setting::
 
 in your :file:`matplotlibrc` file.
 
+``bar`` and ``barh``
+====================
+
+The default value of the ``align`` kwarg for both
+`~matplotlib.Axes.bar` and `~matplotlib.Axes.barh` is changed from
+``'edge'`` to ``'center'``.
+
+
+.. plot::
+
+   import matplotlib.pyplot as plt
+   import numpy as np
+
+   fig, ((ax1, ax2), (ax3, ax4)) = plt.subplots(2, 2, figsize=(5, 5))
+
+   def demo(bar_func, bar_kwargs):
+       return bar_func([1, 2, 3], [1, 2, 3], tick_label=['a', 'b', 'c'],
+                       **bar_kwargs)
+
+
+   ax1.set_title('2.0')
+
+   ax2.set_title("classic alignment")
+
+   demo(ax1.bar, {})
+   demo(ax2.bar, {'align': 'edge'})
+   demo(ax3.barh, {})
+   demo(ax4.barh, {'align': 'edge'})
+
+
+To restore the previous behavior explicitly pass the keyword argument
+``align='edge'`` to the method call.
+
 
 Hatching
 ========
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -1980,7 +1980,11 @@ def bar(self, left, height, width=0.8, bottom=None, **kwargs):
         error_kw.setdefault('ecolor', ecolor)
         error_kw.setdefault('capsize', capsize)
 
-        align = kwargs.pop('align', 'edge')
+        if rcParams['_internal.classic_mode']:
+            align = kwargs.pop('align', 'edge')
+        else:
+            align = kwargs.pop('align', 'center')
+
         orientation = kwargs.pop('orientation', 'vertical')
         log = kwargs.pop('log', False)
         label = kwargs.pop('label', '')
diff --git a/lib/matplotlib/tests/test_artist.py b/lib/matplotlib/tests/test_artist.py
@@ -185,7 +185,7 @@ def test_default_edges():
 
     ax1.plot(np.arange(10), np.arange(10), 'x',
              np.arange(10) + 1, np.arange(10), 'o')
-    ax2.bar(np.arange(10), np.arange(10))
+    ax2.bar(np.arange(10), np.arange(10), align='edge')
     ax3.text(0, 0, "BOX", size=24, bbox=dict(boxstyle='sawtooth'))
     ax3.set_xlim((-1, 1))
     ax3.set_ylim((-1, 1))
