Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 440cb1e

Browse files
committed
Fixed deprecated APIs in lines.py
1 parent ff552f4 commit 440cb1e

File tree

3 files changed

+8
-21
lines changed

3 files changed

+8
-21
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
``set_xdata`` and ``set_ydata`` requires an iterable.
2+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3+
4+
These APIs require argument which is iterable, use of non sequence type is not supported.

lib/matplotlib/lines.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,14 +1276,7 @@ def set_xdata(self, x):
12761276
x : 1D array
12771277
"""
12781278
if not np.iterable(x):
1279-
# When deprecation cycle is completed
1280-
# raise RuntimeError('x must be a sequence')
1281-
_api.warn_deprecated(
1282-
since="3.7",
1283-
message="Setting data with a non sequence type "
1284-
"is deprecated since %(since)s and will be "
1285-
"remove %(removal)s")
1286-
x = [x, ]
1279+
raise RuntimeError('x must be a sequence')
12871280
self._xorig = copy.copy(x)
12881281
self._invalidx = True
12891282
self.stale = True
@@ -1297,14 +1290,7 @@ def set_ydata(self, y):
12971290
y : 1D array
12981291
"""
12991292
if not np.iterable(y):
1300-
# When deprecation cycle is completed
1301-
# raise RuntimeError('y must be a sequence')
1302-
_api.warn_deprecated(
1303-
since="3.7",
1304-
message="Setting data with a non sequence type "
1305-
"is deprecated since %(since)s and will be "
1306-
"remove %(removal)s")
1307-
y = [y, ]
1293+
raise RuntimeError('y must be a sequence')
13081294
self._yorig = copy.copy(y)
13091295
self._invalidy = True
13101296
self.stale = True

lib/matplotlib/tests/test_lines.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,9 @@ def test_invalid_line_data():
9292
mlines.Line2D([], 1)
9393

9494
line = mlines.Line2D([], [])
95-
# when deprecation cycle is completed
96-
# with pytest.raises(RuntimeError, match='x must be'):
97-
with pytest.warns(mpl.MatplotlibDeprecationWarning):
95+
with pytest.raises(RuntimeError, match='x must be'):
9896
line.set_xdata(0)
99-
# with pytest.raises(RuntimeError, match='y must be'):
100-
with pytest.warns(mpl.MatplotlibDeprecationWarning):
97+
with pytest.raises(RuntimeError, match='y must be'):
10198
line.set_ydata(0)
10299

103100

0 commit comments

Comments
 (0)