testing: add KnownFailureDidNotFailTest

astraw · astraw · commit 452413416b10 · 2009-09-06T01:42:16.000Z
svn path=/trunk/matplotlib/; revision=7641
diff --git a/lib/matplotlib/testing/decorators.py b/lib/matplotlib/testing/decorators.py
@@ -1,4 +1,5 @@
-from matplotlib.testing.noseclasses import KnownFailureTest
+from matplotlib.testing.noseclasses import KnownFailureTest, \
+     KnownFailureDidNotFailTest
 import sys
 
 def knownfailureif(fail_condition, msg=None):
@@ -18,7 +19,8 @@ def failer(*args, **kwargs):
                     raise KnownFailureTest(msg)
                 else:
                     raise
-            # Fixme: Should raise KnownFailureDidNotFail if fail_condition==True?
+            if fail_condition:
+                raise KnownFailureDidNotFailTest(msg)
             return result
         return nose.tools.make_decorator(f)(failer)
     return known_fail_decorator
diff --git a/lib/matplotlib/testing/noseclasses.py b/lib/matplotlib/testing/noseclasses.py
@@ -5,6 +5,10 @@ class KnownFailureTest(Exception):
     '''Raise this exception to mark a test as a known failing test.'''
     pass
 
+class KnownFailureDidNotFailTest(Exception):
+    '''Raise this exception to mark a test should have failed but did not.'''
+    pass
+
 class KnownFailure(ErrorClassPlugin):
     '''Plugin that installs a KNOWNFAIL error class for the
     KnownFailureClass exception.  When KnownFailureTest is raised,
