Deprecate NavigationToolbar2QT.adj_window (unused and always None).

anntzer · anntzer · commit 4649e21da87b · 2019-03-19T11:12:46.000+01:00
All's in the changelog.
diff --git a/doc/api/next_api_changes/2019-03-20-AL.rst b/doc/api/next_api_changes/2019-03-20-AL.rst
@@ -0,0 +1,5 @@
+Deprecations
+````````````
+
+The (unused and always None) ``NavigationToolbar2QT.adj_window`` attribute is
+deprecated.
diff --git a/lib/matplotlib/backends/backend_qt5.py b/lib/matplotlib/backends/backend_qt5.py
@@ -726,16 +726,18 @@ def _init_toolbar(self):
             labelAction = self.addWidget(self.locLabel)
             labelAction.setVisible(True)
 
-        # reference holder for subplots_adjust window
-        self.adj_window = None
-
         # Esthetic adjustments - we need to set these explicitly in PyQt5
         # otherwise the layout looks different - but we don't want to set it if
         # not using HiDPI icons otherwise they look worse than before.
         if is_pyqt5():
             self.setIconSize(QtCore.QSize(24, 24))
             self.layout().setSpacing(12)
 
+    @cbook.deprecated("3.1")
+    @property
+    def adj_window(self):
+        return None
+
     if is_pyqt5():
         # For some reason, self.setMinimumHeight doesn't seem to carry over to
         # the actual sizeHint, so override it instead in order to make the
