Merge pull request #13432 from ImportanceOfBeingErnest/reallyfixartistinspector

jklymak · web-flow · commit 46a704e22079 · 2019-02-14T11:03:00.000-08:00
Really fix ArtistInspector.get_aliases
diff --git a/lib/matplotlib/artist.py b/lib/matplotlib/artist.py
@@ -1209,7 +1209,7 @@ def get_aliases(self):
                 continue
             propname = re.search("`({}.*)`".format(name[:4]),  # get_.*/set_.*
                                  inspect.getdoc(func)).group(1)
-            aliases.setdefault(propname, set()).add(name[4:])
+            aliases.setdefault(propname[4:], set()).add(name[4:])
         return aliases
 
     _get_valid_values_regex = re.compile(
diff --git a/lib/matplotlib/tests/test_artist.py b/lib/matplotlib/tests/test_artist.py
@@ -277,3 +277,10 @@ def set_f(self, arg):
     """ % accept_clause
     valid_values = martist.ArtistInspector(TestArtist).get_valid_values('f')
     assert valid_values == expected
+
+
+def test_artist_inspector_get_aliases():
+    # test the correct format and type of get_aliases method
+    ai = martist.ArtistInspector(mlines.Line2D)
+    aliases = ai.get_aliases()
+    assert aliases["linewidth"] == {"lw"}
