Make lualatex version functions private

maxnoe · maxnoe · commit 476ff78a0ed2 · 2018-02-24T10:10:57.000+01:00
diff --git a/lib/matplotlib/backends/backend_pgf.py b/lib/matplotlib/backends/backend_pgf.py
@@ -52,7 +52,7 @@
         warnings.warn('error getting fonts from fc-list', UserWarning)
 
 
-luatex_version_re = re.compile(
+_luatex_version_re = re.compile(
     'This is LuaTeX, Version (?:beta-)?([0-9]+)\.([0-9]+)\.([0-9]+)'
 )
 
@@ -64,15 +64,15 @@ def get_texcommand():
     return texsystem if texsystem in texsystem_options else "xelatex"
 
 
-def get_lualatex_version():
+def _get_lualatex_version():
     """Get version of luatex"""
     output = check_output(['lualatex', '--version'])
-    return parse_lualatex_version(output.decode())
+    return _parse_lualatex_version(output.decode())
 
 
-def parse_lualatex_version(output):
+def _parse_lualatex_version(output):
     '''parse the lualatex version from the output of `lualatex --version`'''
-    match = luatex_version_re.match(output)
+    match = _luatex_version_re.match(output)
     return tuple(map(int, match.groups()))
 
 
@@ -1199,7 +1199,7 @@ def savefig(self, figure=None, **kwargs):
                 self._write_header(*figure.get_size_inches())
             else:
                 if get_texcommand() == 'lualatex':
-                    if get_lualatex_version() > (0, 85, 0):
+                    if _get_lualatex_version() > (0, 85, 0):
                         np = r'\newpage\pagewidth={}in\pageheight={}in%'
                     else:
                         np = r'\newpage\pdfpagewidth={}in\pdfpageheight={}in%'
diff --git a/lib/matplotlib/tests/test_backend_pgf.py b/lib/matplotlib/tests/test_backend_pgf.py
@@ -280,8 +280,8 @@ def test_pdf_pages_lualatex():
 
 @needs_lualatex
 def test_luatex_version():
-    from matplotlib.backends.backend_pgf import parse_lualatex_version
-    from matplotlib.backends.backend_pgf import get_lualatex_version
+    from matplotlib.backends.backend_pgf import _parse_lualatex_version
+    from matplotlib.backends.backend_pgf import _get_lualatex_version
 
     v1 = '''This is LuaTeX, Version 1.0.4 (TeX Live 2017)
 
@@ -307,9 +307,9 @@ def test_luatex_version():
 Copyright 2013 Taco Hoekwater, the LuaTeX Team.
 '''
 
-    assert parse_lualatex_version(v1) == (1, 0, 4)
-    assert parse_lualatex_version(v2) == (0, 76, 0)
+    assert _parse_lualatex_version(v1) == (1, 0, 4)
+    assert _parse_lualatex_version(v2) == (0, 76, 0)
 
     # just test if it is successful
-    version = get_lualatex_version()
+    version = _get_lualatex_version()
     assert len(version) == 3
