Deprecate the unneeded Fonts.destroy.

anntzer · anntzer · commit 4831578abcbf · 2020-07-21T22:16:06.000+02:00
Neither `used_characters` nor `glyphd` cause circular references, so we
can let the normal refcount collector handle the destruction.
diff --git a/doc/api/next_api_changes/deprecations/18003-AL.rst b/doc/api/next_api_changes/deprecations/18003-AL.rst
@@ -0,0 +1,3 @@
+mathtext.Fonts.destroy
+~~~~~~~~~~~~~~~~~~~~~~
+... is deprecated, because Fonts do not create reference loops anyways.
diff --git a/lib/matplotlib/mathtext.py b/lib/matplotlib/mathtext.py
@@ -398,6 +398,7 @@ def __init__(self, default_font_prop, mathtext_backend):
         self.mathtext_backend = mathtext_backend
         self.used_characters = {}
 
+    @cbook.deprecated("3.4")
     def destroy(self):
         """
         Fix any cyclical references before the object is about
@@ -519,7 +520,9 @@ def get_results(self, box):
         """
         result = self.mathtext_backend.get_results(
             box, self.get_used_characters())
-        self.destroy()
+        if self.destroy != TruetypeFonts.destroy.__get__(self):
+            cbook._deprecate_method_override(
+                __class__.destroy, self, since="3.4")()
         return result
 
     def get_sized_alternatives_for_symbol(self, fontname, sym):
@@ -547,6 +550,7 @@ def __init__(self, default_font_prop, mathtext_backend):
         self._fonts['default'] = default_font
         self._fonts['regular'] = default_font
 
+    @cbook.deprecated("3.4")
     def destroy(self):
         self.glyphd = None
         Fonts.destroy(self)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+mathtext.Fonts.destroy`
	`2`	`+~~~~~~~~~~~~~~~~~~~~~~`
	`3`	`+... is deprecated, because Fonts do not create reference loops anyways.`