[3054467] fix bug in PatchCollection; restore attribute access to Patch.fill

efiring · efiring · commit 4a1d0510c270 · 2010-09-01T19:44:36.000Z
svn path=/branches/v1_0_maint/; revision=8673
diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
@@ -1034,7 +1034,7 @@ def __init__(self, patches, match_original=False, **kwargs):
 
         if match_original:
             def determine_facecolor(patch):
-                if patch.fill:
+                if patch.get_fill():
                     return patch.get_facecolor()
                 return [0, 0, 0, 0]
 
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -312,13 +312,18 @@ def set_fill(self, b):
 
         ACCEPTS: [True | False]
         """
-        self._fill = b
+        self._fill = bool(b)
         self.set_facecolor(self._original_facecolor)
 
     def get_fill(self):
         'return whether fill is set'
         return self._fill
 
+    # Make fill a property so as to preserve the long-standing
+    # but somewhat inconsistent behavior in which fill was an
+    # attribute.
+    fill = property(get_fill, set_fill)
+
     def set_hatch(self, hatch):
         """
         Set the hatching pattern
