Merge pull request #13711 from anntzer/tktoolbaractive

efiring · web-flow · commit 4d1a2de05f88 · 2019-05-22T10:25:32.000-10:00
Deprecate NavigationToolbar2Tk.set_active.
diff --git a/doc/api/next_api_changes/2019-03-19-AL.rst b/doc/api/next_api_changes/2019-03-19-AL.rst
@@ -0,0 +1,4 @@
+Deprecations
+````````````
+``NavigationToolbar2Tk.set_active`` is deprecated, as it has no (observable)
+effect.
diff --git a/examples/user_interfaces/embedding_in_wx3_sgskip.py b/examples/user_interfaces/embedding_in_wx3_sgskip.py
@@ -12,9 +12,9 @@
 This is yet another example of using matplotlib with wx.  Hopefully
 this is pretty full-featured:
 
-  - both matplotlib toolbar and WX buttons manipulate plot
-  - full wxApp framework, including widget interaction
-  - XRC (XML wxWidgets resource) file to create GUI (made with XRCed)
+- both matplotlib toolbar and WX buttons manipulate plot
+- full wxApp framework, including widget interaction
+- XRC (XML wxWidgets resource) file to create GUI (made with XRCed)
 
 This was derived from embedding_in_wx and dynamic_image_wxagg.
 
@@ -46,7 +46,6 @@ def __init__(self, parent):
         self.canvas = FigureCanvas(self, -1, self.fig)
         self.toolbar = NavigationToolbar(self.canvas)  # matplotlib toolbar
         self.toolbar.Realize()
-        # self.toolbar.set_active([0,1])
 
         # Now put all into a sizer
         sizer = wx.BoxSizer(wx.VERTICAL)
diff --git a/lib/matplotlib/backends/_backend_tk.py b/lib/matplotlib/backends/_backend_tk.py
@@ -637,6 +637,7 @@ def save_figure(self, *args):
         except Exception as e:
             tkinter.messagebox.showerror("Error saving file", str(e))
 
+    @cbook.deprecated("3.1")
     def set_active(self, ind):
         self._ind = ind
         self._active = [self._axes[i] for i in self._ind]
