FIX: QuantityND should return NotImplemented rather than raise

greglucas · greglucas · commit 4e8972d29e66 · 2022-07-30T08:40:02.000-06:00
__array_ufunc__ should "return" rather than "raise" when something
is not handled within it.
diff --git a/lib/matplotlib/tests/test_image.py b/lib/matplotlib/tests/test_image.py
@@ -1163,7 +1163,7 @@ def __getitem__(self, item):
     def __array_ufunc__(self, ufunc, method, *inputs, **kwargs):
         func = getattr(ufunc, method)
         if "out" in kwargs:
-            raise NotImplementedError
+            return NotImplemented
         if len(inputs) == 1:
             i0 = inputs[0]
             unit = getattr(i0, "units", "dimensionless")
@@ -1184,10 +1184,10 @@ def __array_ufunc__(self, ufunc, method, *inputs, **kwargs):
             elif ufunc == np.divide:
                 unit = f"{u0}/({u1})"
             else:
-                raise NotImplementedError
+                return NotImplemented
             out_arr = func(i0.view(np.ndarray), i1.view(np.ndarray), **kwargs)
         else:
-            raise NotImplementedError
+            return NotImplemented
         if unit is None:
             out_arr = np.array(out_arr)
         else:
