label_outer() should remove inner minor ticks too.

anntzer · anntzer · commit 4f6320edc46f · 2016-09-09T10:14:57.000-07:00
Minimal example:

    fig, axs = plt.subplots(2, 2, sharex=True, sharey=True)
    axs[0, 0].set(xscale="log", yscale="log", xlim=(1, 10))
    for ax in axs: ax.label_outer()

Also, do not switch back on visibility of outer offset text if it was
not visible before.
diff --git a/lib/matplotlib/axes/_subplots.py b/lib/matplotlib/axes/_subplots.py
@@ -134,15 +134,15 @@ def label_outer(self):
         """
         lastrow = self.is_last_row()
         firstcol = self.is_first_col()
-        for label in self.get_xticklabels():
-            label.set_visible(lastrow)
-        self.get_xaxis().get_offset_text().set_visible(lastrow)
         if not lastrow:
+            for label in self.get_xticklabels(which="both"):
+                label.set_visible(False)
+            self.get_xaxis().get_offset_text().set_visible(False)
             self.set_xlabel("")
-        for label in self.get_yticklabels():
-            label.set_visible(firstcol)
-        self.get_yaxis().get_offset_text().set_visible(firstcol)
         if not firstcol:
+            for label in self.get_yticklabels(which="both"):
+                label.set_visible(False)
+            self.get_yaxis().get_offset_text().set_visible(False)
             self.set_ylabel("")
 
     def _make_twin_axes(self, *kl, **kwargs):
