Check file path for animation and raise if it does not exist

oscargus · oscargus · commit 51af37fc62a4 · 2023-02-20T08:54:08.000+01:00
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -193,6 +193,8 @@ def setup(self, fig, outfile, dpi=None):
             The DPI (or resolution) for the file.  This controls the size
             in pixels of the resulting movie file.
         """
+        # Check that path is valid
+        Path(outfile).parent.resolve(strict=True)
         self.outfile = outfile
         self.fig = fig
         if dpi is None:
@@ -405,11 +407,7 @@ def setup(self, fig, outfile, dpi=None, frame_prefix=None):
             deleted by `finish`; if not *None*, no temporary files are
             deleted.
         """
-        self.fig = fig
-        self.outfile = outfile
-        if dpi is None:
-            dpi = self.fig.dpi
-        self.dpi = dpi
+        super().setup(fig, outfile, dpi=dpi)
         self._adjust_frame_size()
 
         if frame_prefix is None:
diff --git a/lib/matplotlib/tests/test_animation.py b/lib/matplotlib/tests/test_animation.py
@@ -506,3 +506,10 @@ def test_disable_cache_warning(anim):
         )
     assert anim._cache_frame_data is False
     anim._init_draw()
+
+
+def test_movie_writer_invalid_path(anim):
+    with pytest.raises(FileNotFoundError,
+                       match=re.escape("[Errno 2] No such file or directory: '/foo")):
+        anim.save("/foo/bar/aardvark/thiscannotreallyexist.mp4",
+                  writer=animation.FFMpegFileWriter())
