Merge pull request #12117 from dstansby/extents

NelleV · web-flow · commit 5235f5284570 · 2018-09-15T04:27:26.000-07:00
Fix Agg extent calculations for empty draws
diff --git a/lib/matplotlib/tests/test_backend_pdf.py b/lib/matplotlib/tests/test_backend_pdf.py
@@ -232,3 +232,11 @@ def test_failing_latex(tmpdir):
     plt.xlabel("$22_2_2$")
     with pytest.raises(RuntimeError):
         plt.savefig(path)
+
+
+def test_empty_rasterised():
+    # Check that emtpy figures that are rasterised save to pdf files fine
+    with PdfPages(io.BytesIO()) as pdf:
+        fig, ax = plt.subplots()
+        ax.plot([], [], rasterized=True)
+        fig.savefig(pdf, format="pdf")
diff --git a/src/_backend_agg.cpp b/src/_backend_agg.cpp
@@ -201,10 +201,15 @@ agg::rect_i RendererAgg::get_content_extents()
         }
     }
 
-    r.x1 = std::max(0, r.x1);
-    r.y1 = std::max(0, r.y1);
-    r.x2 = std::min(r.x2 + 1, (int)width);
-    r.y2 = std::min(r.y2 + 1, (int)height);
+    if (r.x1 == width && r.x2 == 0) {
+      // The buffer is completely empty.
+      r.x1 = r.y1 = r.x2 = r.y2 = 0;
+    } else {
+      r.x1 = std::max(0, r.x1);
+      r.y1 = std::max(0, r.y1);
+      r.x2 = std::min(r.x2 + 1, (int)width);
+      r.y2 = std::min(r.y2 + 1, (int)height);
+    }
 
     return r;
 }

Original file line number	Diff line number	Diff line change
`@@ -201,10 +201,15 @@ agg::rect_i RendererAgg::get_content_extents()`
`201`	`201`	`}`
`202`	`202`	`}`
`203`	`203`
`204`		`- r.x1 = std::max(0, r.x1);`
`205`		`- r.y1 = std::max(0, r.y1);`
`206`		`- r.x2 = std::min(r.x2 + 1, (int)width);`
`207`		`- r.y2 = std::min(r.y2 + 1, (int)height);`
	`204`	`+ if (r.x1 == width && r.x2 == 0) {`
	`205`	`+ // The buffer is completely empty.`
	`206`	`+ r.x1 = r.y1 = r.x2 = r.y2 = 0;`
	`207`	`+ } else {`
	`208`	`+ r.x1 = std::max(0, r.x1);`
	`209`	`+ r.y1 = std::max(0, r.y1);`
	`210`	`+ r.x2 = std::min(r.x2 + 1, (int)width);`
	`211`	`+ r.y2 = std::min(r.y2 + 1, (int)height);`
	`212`	`+ }`
`208`	`213`
`209`	`214`	`return r;`
`210`	`215`	`}`