Fix IndexError when using scatter3d and depthshade=False (#18156)

neil-ptr · Neilzon Viloria · web-flow · commit 524172f9ee04 · 2020-08-03T18:40:12.000+01:00
* Fix IndexError when using scatter3d and depthshade=False

* flake8 compliance for test_mplot3d.py

* change test_scatter3d_depthshade_false to figure comparison test

* flake8 compliance in test_mplot3d.py

* removed image and changed test_scatter3d_depthshade_false

Co-authored-by: Neilzon Viloria &lt;neil@MacBook-Pro.local&gt;
diff --git a/lib/mpl_toolkits/mplot3d/art3d.py b/lib/mpl_toolkits/mplot3d/art3d.py
@@ -508,8 +508,9 @@ def do_3d_projection(self, renderer):
         vzs = vzs[z_markers_idx]
         vxs = vxs[z_markers_idx]
         vys = vys[z_markers_idx]
-        fcs = fcs[z_markers_idx]
-        ecs = ecs[z_markers_idx]
+        if self._depthshade:
+            fcs = fcs[z_markers_idx]
+            ecs = ecs[z_markers_idx]
         if len(sizes) > 1:
             sizes = sizes[z_markers_idx]
         vps = np.column_stack((vxs, vys))
diff --git a/lib/mpl_toolkits/tests/test_mplot3d.py b/lib/mpl_toolkits/tests/test_mplot3d.py
@@ -242,6 +242,17 @@ def test_scatter3d_color():
                color='b', marker='s')
 
 
+def test_scatter3d_depthshade_false():
+    """
+    Test that 3d scatter plot doesn't throw
+    IndexError with depthshade=False (issue #18037)
+    """
+    x = y = z = np.arange(16)
+    fig_test = plt.figure()
+    ax_test = fig_test.add_subplot(projection='3d')
+    ax_test.scatter(x, y, z, depthshade=False)
+
+
 @check_figures_equal(extensions=['png'])
 def test_scatter3d_size(fig_ref, fig_test):
     """Test that large markers in correct position (issue #18135)"""
