Remove vmin, vmax of span selector, use extents instead

ericpre · ericpre · commit 524f2b79315e · 2021-06-03T22:39:31.000+01:00
diff --git a/lib/matplotlib/tests/test_widgets.py b/lib/matplotlib/tests/test_widgets.py
@@ -236,27 +236,27 @@ def onselect(epress, erelease):
     do_event(tool, 'press', xdata=10, ydata=10, button=1)
     do_event(tool, 'onmove', xdata=100, ydata=120, button=1)
     do_event(tool, 'release', xdata=100, ydata=120, button=1)
-    assert (tool.vmin, tool.vmax) == (10, 100)
+    assert tool.extents == (10, 100)
     # Drag inside span
     #
     # If drag_from_anywhere == True, this will move the span by 10,
-    # giving new value vmin, vmax = 20, 110
+    # giving new value extents = 20, 110
     #
     # If drag_from_anywhere == False, this will create a new span with
-    # value vmin, vmax = 25, 35
+    # value vmin, vmaxextents = 25, 35
     do_event(tool, 'press', xdata=25, ydata=15, button=1)
     do_event(tool, 'onmove', xdata=35, ydata=25, button=1)
     do_event(tool, 'release', xdata=35, ydata=25, button=1)
     if drag_from_anywhere:
-        assert (tool.vmin, tool.vmax) == (20, 110)
+        assert tool.extents == (20, 110)
     else:
-        assert (tool.vmin, tool.vmax) == (25, 35)
+        assert tool.extents == (25, 35)
 
     # Check that in both cases, dragging outside the span draws a new span
     do_event(tool, 'press', xdata=175, ydata=185, button=1)
     do_event(tool, 'onmove', xdata=185, ydata=195, button=1)
     do_event(tool, 'release', xdata=185, ydata=195, button=1)
-    assert (tool.vmin, tool.vmax) == (175, 185)
+    assert tool.extents == (175, 185)
 
 
 def test_tool_line_handle():
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -2196,27 +2196,15 @@ def _contains(self, event):
         return self._rect.contains(event, radius=0)[0]
 
     @property
-    def vmin(self):
-        """Get the start span coordinate."""
+    def extents(self):
+        """Return extents of the span selector."""
         if self.direction == 'horizontal':
             vmin = self._rect.get_x()
+            vmax = vmin + self._rect.get_width()
         else:
             vmin = self._rect.get_y()
-        return vmin
-
-    @property
-    def vmax(self):
-        """Get the end span coordinate."""
-        if self.direction == 'horizontal':
-            vmax = self.vmin + self._rect.get_width()
-        else:
-            vmax = self.vmin + self._rect.get_height()
-        return vmax
-
-    @property
-    def extents(self):
-        """Return (vmin, vmax)."""
-        return self.vmin, self.vmax
+            vmax = vmin + self._rect.get_height()
+        return vmin, vmax
 
     @extents.setter
     def extents(self, extents):
