Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 529da92

Browse files
melissawmstory645QuLogic
authored
DOC: Add note about opening multiple PRs (#31329)
* DOC: Add note about opening multiple PRs * Wording * Move note about finishing PRs to before PR template * Add admonition as important instead of note Co-authored-by: hannah <[email protected]> * Accept review suggestion Co-authored-by: Elliott Sales de Andrade <[email protected]> --------- Co-authored-by: hannah <[email protected]> Co-authored-by: Elliott Sales de Andrade <[email protected]>
1 parent 25f1939 commit 529da92

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

.github/workflows/pr_welcome.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ jobs:
2626
If you have not heard from us in a week or so, please leave a new
2727
comment below and that should bring it to our attention.
2828
Most of our reviewers are volunteers and sometimes things fall
29-
through the cracks.
29+
through the cracks. We also ask that you please finish addressing
30+
any review comments on this PR and wait for it to be merged (or
31+
closed) before opening a new one, as it can be a valuable learning
32+
experience to go through the review process.
3033
3134
3235
You can also join us [on
@@ -38,7 +41,7 @@ jobs:
3841
please see [the developer
3942
guide](https://matplotlib.org/devdocs/devel/index.html).
4043
41-
**Please let us know if (and how) you use AI, it will help us give you
44+
**Please let us know if (and how) you use AI, it will help us give you
4245
better feedback on your PR.**
4346
4447

doc/devel/contribute.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,14 @@ guide you through each step:
304304
and ensure you understand/are able to complete the template when you open your pull request.
305305
Additional information can be found in the `pull request guidelines <https://matplotlib.org/devdocs/devel/pr_guide.html>`_.
306306

307+
.. important::
308+
309+
Make sure you finish addressing any review comments on your first PR and wait
310+
for it to be merged (or closed) before opening a new one. It can be a valuable
311+
learning experience to go through the review process and to get feedback on
312+
your contribution, while also helping maintainers spend their time
313+
effectively.
314+
307315
.. dropdown:: `Pull request template <https://github.com/matplotlib/matplotlib/blob/main/.github/PULL_REQUEST_TEMPLATE.md>`_
308316
:open:
309317

0 commit comments

Comments
 (0)