Inline FigureCanvasGtkFoo._render_figure.

anntzer · anntzer · commit 53e82d38bc6d · 2020-05-20T15:07:44.000+02:00
Having it as a separate function obscures the flow for little benefit,
and caused an unnecessary call to get_allocation() in gtk3agg.
diff --git a/lib/matplotlib/backends/backend_gtk3agg.py b/lib/matplotlib/backends/backend_gtk3agg.py
@@ -20,9 +20,6 @@ def __init__(self, figure):
     def _renderer_init(self):
         pass
 
-    def _render_figure(self, width, height):
-        backend_agg.FigureCanvasAgg.draw(self)
-
     def on_draw_event(self, widget, ctx):
         """GtkDrawable draw event, like expose_event in GTK 2.X."""
         allocation = self.get_allocation()
@@ -74,8 +71,7 @@ def blit(self, bbox=None):
 
     def draw(self):
         if self.get_visible() and self.get_mapped():
-            allocation = self.get_allocation()
-            self._render_figure(allocation.width, allocation.height)
+            backend_agg.FigureCanvasAgg.draw(self)
         super().draw()
 
     def print_png(self, filename, *args, **kwargs):
diff --git a/lib/matplotlib/backends/backend_gtk3cairo.py b/lib/matplotlib/backends/backend_gtk3cairo.py
@@ -20,10 +20,6 @@ def _renderer_init(self):
         """Use cairo renderer."""
         self._renderer = RendererGTK3Cairo(self.figure.dpi)
 
-    def _render_figure(self, width, height):
-        self._renderer.set_width_height(width, height)
-        self.figure.draw(self._renderer)
-
     def on_draw_event(self, widget, ctx):
         """GtkDrawable draw event."""
         with (self.toolbar._wait_cursor_for_draw_cm() if self.toolbar
@@ -34,7 +30,9 @@ def on_draw_event(self, widget, ctx):
                 self.get_style_context(), ctx,
                 allocation.x, allocation.y,
                 allocation.width, allocation.height)
-            self._render_figure(allocation.width, allocation.height)
+            self._renderer.set_width_height(
+                allocation.width, allocation.height)
+            self.figure.draw(self._renderer)
 
 
 @_BackendGTK3.export
