BUG: Avoid set_children when unpickling TransformWrapper.

QuLogic · QuLogic · commit 5478183d18d6 · 2015-09-12T21:31:32.000-04:00
Calling set_children may or may not work if the child has been unpickled
yet, and it actually causes duplicate parents to be set in the times
when it does appear to work.
diff --git a/lib/matplotlib/transforms.py b/lib/matplotlib/transforms.py
@@ -1533,6 +1533,10 @@ def __init__(self, child):
             msg = ("'child' must be an instance of"
                    " 'matplotlib.transform.Transform'")
             raise ValueError(msg)
+        self._init(child)
+        self.set_children(child)
+
+    def _init(self, child):
         Transform.__init__(self)
         self.input_dims = child.input_dims
         self.output_dims = child.output_dims
@@ -1553,7 +1557,7 @@ def __getstate__(self):
 
     def __setstate__(self, state):
         # re-initialise the TransformWrapper with the state's child
-        self.__init__(state['child'])
+        self._init(state['child'])
 
     def __repr__(self):
         return "TransformWrapper(%r)" % self._child
@@ -1564,7 +1568,6 @@ def frozen(self):
 
     def _set(self, child):
         self._child = child
-        self.set_children(child)
 
         self.transform = child.transform
         self.transform_affine = child.transform_affine
@@ -1593,6 +1596,7 @@ def set(self, child):
                    " output dimensions as the current child.")
             raise ValueError(msg)
 
+        self.set_children(child)
         self._set(child)
 
         self._invalid = 0
