MNT: consolidate tick_label logic

tacaswell · tacaswell · commit 5539a4287db8 · 2015-10-13T13:39:06.000-04:00
Collect (almost) all of the logic for the bar tick_label in one place. Closes #5237
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -1980,9 +1980,6 @@ def bar(self, left, height, width=0.8, bottom=None, **kwargs):
         edgecolor = kwargs.pop('edgecolor', None)
         linewidth = kwargs.pop('linewidth', None)
 
-        tick_label = kwargs.pop('tick_label', None)
-        label_ticks_flag = tick_label is not None
-
         # Because xerr and yerr will be passed to errorbar,
         # most dimension checking and processing will be left
         # to the errorbar method.
@@ -1998,6 +1995,7 @@ def bar(self, left, height, width=0.8, bottom=None, **kwargs):
         orientation = kwargs.pop('orientation', 'vertical')
         log = kwargs.pop('log', False)
         label = kwargs.pop('label', '')
+        tick_labels = kwargs.pop('tick_label', None)
 
         def make_iterable(x):
             if not iterable(x):
@@ -2013,7 +2011,6 @@ def make_iterable(x):
         _bottom = bottom
         bottom = make_iterable(bottom)
         linewidth = make_iterable(linewidth)
-        tick_label = make_iterable(tick_label)
 
         adjust_ylim = False
         adjust_xlim = False
@@ -2058,8 +2055,6 @@ def make_iterable(x):
 
         if len(linewidth) < nbars:
             linewidth *= nbars
-        if len(tick_label) < nbars:
-            tick_label *= nbars
 
         if color is None:
             color = [None] * nbars
@@ -2092,9 +2087,6 @@ def make_iterable(x):
         if len(bottom) != nbars:
             raise ValueError("incompatible sizes: argument 'bottom' "
                              "must be length %d or scalar" % nbars)
-        if len(tick_label) != nbars:
-            raise ValueError("incompatible sizes: argument 'tick_label' "
-                             "must be length %d or string" % nbars)
 
         patches = []
 
@@ -2190,9 +2182,16 @@ def make_iterable(x):
         bar_container = BarContainer(patches, errorbar, label=label)
         self.add_container(bar_container)
 
-        if label_ticks_flag:
+        if tick_labels is not None:
+            tick_labels = make_iterable(tick_labels)
+            if not is_sequence_of_strings(tick_labels):
+                raise ValueError("tick_label must be a sequence of strings")
+            if len(tick_labels) != tick_label_position:
+                raise ValueError("incompatible sizes: argument 'tick_label' "
+                                 "must be length %d or string" % nbars)
+
             tick_label_axis.set_ticks(tick_label_position)
-            tick_label_axis.set_ticklabels(tick_label)
+            tick_label_axis.set_ticklabels(tick_labels)
 
         return bar_container
 
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -1055,6 +1055,12 @@ def test_bar_tick_label_single():
     ax.bar("a", "b" , tick_label='a', data=data)
 
 
+@cleanup
+def test_bar_ticklabel_fail():
+    fig, ax = plt.subplots()
+    ax.bar([], [])
+
+
 @image_comparison(baseline_images=['bar_tick_label_multiple'],
                   extensions=['png'])
 def test_bar_tick_label_multiple():
@@ -1082,6 +1088,7 @@ def test_hist_log():
     ax = fig.add_subplot(111)
     ax.hist(data, fill=False, log=True)
 
+
 @image_comparison(baseline_images=['hist_bar_empty'], remove_text=True,
 	extensions=['png'])
 def test_hist_bar_empty():
